[Docs] Clarify incompatibility between UPDATE_FLEXIBLE_COLUMNS and columns parameter#3630
Open
Manas756 wants to merge 4 commits into
Open
[Docs] Clarify incompatibility between UPDATE_FLEXIBLE_COLUMNS and columns parameter#3630Manas756 wants to merge 4 commits into
Manas756 wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the navbar brand/logo styling to change how the logo is sized/aligned and how overflow is handled within the navbar header.
Changes:
- Converted
.navbar__brandand.navbar__logoto flex containers with vertical centering. - Replaced fixed heights with min/max-height constraints and adjusted image sizing rules.
- Switched overflow from
hiddentovisiblefor brand/logo areas.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
127
to
+133
| &__brand { | ||
| height: 1.875rem; | ||
| display: flex; | ||
| align-items: center; | ||
| min-height: 1.875rem; | ||
| margin: 0; | ||
| margin-right: 2.75rem; | ||
| overflow: hidden; | ||
| overflow: visible; |
Comment on lines
147
to
+152
| img { | ||
| display: block; | ||
| width: auto; | ||
| height: 100%; | ||
| max-height: 1.875rem; | ||
| object-fit: contain; |
Contributor
Author
|
Hi maintainers, this PR fixes issue #3592. Kindly review. |
Contributor
Author
|
Could a maintainer please trigger the CI? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The documentation does not mention that
UPDATE_FLEXIBLE_COLUMNSis incompatible with thecolumnsparameter.Root Cause
columnsenforces a fixed schema, while flexible partial update requires dynamic column handling.Solution
Added a warning note and usage examples to clarify this limitation.
Verification
Verified behavior with test data:
columns→ partial update fails (fields may become NULL)columns→ partial update works correctlyFixes #3592