Commit 3da727f
committed
[test](geo) drop redundant assert_cast on already-typed null_map column
### What problem does this PR solve?
Issue Number: close #N/A
Problem Summary:
BE-UT has been failing master-wide since both PR #63491 (which strongly
typed `ColumnNullable::get_null_map_column[_ptr]()` to `ColumnUInt8`) and
PR #63049 (which added `functions_geo_test.cpp`) landed today. The new
test calls
```cpp
assert_cast<ColumnUInt8*>(nullable_input->get_null_map_column_ptr().get())
->insert_value(0);
```
but the inner expression is already `ColumnUInt8*`, so the cast triggers
the same-type static_assert added by PR #63133 to `src/core/assert_cast.h`:
```
static assertion failed due to requirement
'!std::is_same_v<doris::ColumnVector<doris::TYPE_BOOLEAN> *,
doris::ColumnVector<doris::TYPE_BOOLEAN> *>':
assert_cast is redundant for the same type after removing cv/ref qualifiers
```
That kills `doris_be_test` compilation on every PR that runs BE-UT.
Use the strongly typed `get_null_map_column()` (which returns
`ColumnUInt8&`) directly so the cast is no longer needed.
### Release note
None (test-only change, restores BE-UT compilation on master).
### Check List (For Author)
- Test:
- Compile-check on local ASAN tree: the affected translation unit
now builds clean (`ninja test/CMakeFiles/doris_be_test.dir/exprs/function/geo/functions_geo_test.cpp.o`).
- Behavior changed: No
- Does this need documentation: No1 parent 2b08baa commit 3da727f
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
372 | 372 | | |
373 | 373 | | |
374 | 374 | | |
375 | | - | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
376 | 379 | | |
377 | 380 | | |
378 | 381 | | |
| |||
0 commit comments