[Chore](build) enable -Wpedantic and update lowest gcc version to 11.1 (#16290)

enable -Wpedantic and update lowest gcc version to 11.1

Author: BiteTheDDDDt

.clangd

@@ -18,3 +18,8 @@
 Diagnostics:
   UnusedIncludes: Strict
 
+If:
+  PathMatch: be/test/.*
+
+CompileFlags:
+  CompilationDatabase: be/ut_build_ASAN/

be/CMakeLists.txt

@@ -60,7 +60,6 @@ endif ()
 # Set boost/stacktrace use backtrace api to unwind
 if (NOT OS_MACOSX)
     add_definitions(-DBOOST_STACKTRACE_USE_BACKTRACE)
-    #add_definitions(-DPRINT_ALL_ERR_STATUS_STACKTRACE)
 else()
     add_definitions(-DBOOST_STACKTRACE_USE_NOOP)
 endif()
@@ -118,8 +117,8 @@ option(WITH_MYSQL "Support access MySQL" ON)
 
 # Check gcc
 if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
-    if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS "11.0")
-        message(FATAL_ERROR "Need GCC version at least 11.0")
+    if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS "11.1")
+        message(FATAL_ERROR "Need GCC version at least 11.1")
     endif()
 endif()
 
@@ -490,27 +489,25 @@ if (NOT CUSTUM_LINKER_COMMAND STREQUAL "ld")
     set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fuse-ld=${CUSTUM_LINKER_COMMAND}")
 endif()
 
-if (USE_LIBCPP AND COMPILER_CLANG)
-    set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -stdlib=libc++")
-    if (NOT OS_MACOSX)
-        set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -lstdc++")
-    endif()
-    add_definitions(-DUSE_LIBCPP)
-endif()
-
 if (COMPILER_GCC)
-    # Avoid GCC 11 false alarm
-    # https://stackoverflow.com/questions/67584073/gcc-11-false-array-subscript-is-partly-outside-array-bounds-warning
-    # https://stackoverflow.com/questions/69426070/gcc-11-order-of-arguments-triggers-false-positive-wstringop-overflow-is-this-bu
-    set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wno-array-bounds -Wno-stringop-overread")
-    add_compile_options(-Wno-stringop-overflow -fdiagnostics-color=always)
+    add_compile_options(-fdiagnostics-color=always -Wno-array-bounds -Wno-stringop-overread)
 endif ()
 
 if (COMPILER_CLANG)
-    add_compile_options(-fcolor-diagnostics -fno-limit-debug-info)
+    add_compile_options(-fcolor-diagnostics -fno-limit-debug-info -Wpedantic)
+    add_compile_options(-Wno-zero-length-array -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -Wno-vla-extension -Wno-c++20-designator -Wno-gnu-label-as-value -Wno-embedded-directive -Wno-array-bounds)
     if(MAKE_TEST STREQUAL "OFF")
         add_compile_options(-Qunused-arguments)
     endif()
+    if (USE_LIBCPP)
+        add_compile_options(-stdlib=libc++)
+        if (NOT OS_MACOSX)
+            add_compile_options(-lstdc++)
+        endif()
+        add_definitions(-DUSE_LIBCPP)
+    else()
+        add_compile_options(-Wno-c++20-attribute-extensions)
+    endif()
 endif ()
 
 # https://github.com/boostorg/uuid/issues/92

be/src/agent/utils.h

@@ -29,7 +29,7 @@ namespace doris {
 class MasterServerClient {
 public:
     MasterServerClient(const TMasterInfo& master_info, FrontendServiceClientCache* client_cache);
-    virtual ~MasterServerClient() {};
+    virtual ~MasterServerClient() = default;
 
     // Report finished task to the master server
     //
@@ -59,8 +59,8 @@ class MasterServerClient {
 
 class AgentUtils {
 public:
-    AgentUtils() {};
-    virtual ~AgentUtils() {};
+    AgentUtils() = default;
+    virtual ~AgentUtils() = default;
 
     // Execute shell cmd
     virtual bool exec_cmd(const std::string& command, std::string* errmsg,

be/src/common/logging.h

@@ -86,7 +86,7 @@ class TaggableLogger {
         } else {
             _stream << fmt::format(fmt, std::forward<Args>(args)...);
         }
-    };
+    }
 
     template <typename V>
     TaggableLogger& tag(std::string_view key, const V& value) {

be/src/common/status.h

@@ -253,7 +253,7 @@ E(INVERTED_INDEX_CLUCENE_ERROR, -6002);
 E(INVERTED_INDEX_FILE_NOT_FOUND, -6003);
 E(INVERTED_INDEX_FILE_HIT_LIMIT, -6004);
 #undef E
-}; // namespace ErrorCode
+} // namespace ErrorCode
 
 // clang-format off
 // whether to capture stacktrace

be/src/exec/data_sink.h

@@ -59,7 +59,7 @@ class DataSink {
     // Send a Block into this sink.
     virtual Status send(RuntimeState* state, vectorized::Block* block, bool eos = false) {
         return Status::NotSupported("Not support send block");
-    };
+    }
     // Releases all resources that were allocated in prepare()/send().
     // Further send() calls are illegal after calling close().
     // It must be okay to call this multiple times. Subsequent calls should

be/src/exec/olap_common.h

@@ -336,7 +336,7 @@ class ColumnValueRange {
             set_whole_value_range();
         }
         _contain_null = contain_null;
-    };
+    }
 
     int precision() const { return _precision; }
 

be/src/exec/tablet_info.h

@@ -99,7 +99,7 @@ struct VOlapTablePartition {
     std::vector<OlapTableIndexTablets> indexes;
 
     VOlapTablePartition(vectorized::Block* partition_block)
-            : start_key {partition_block, -1}, end_key {partition_block, -1} {};
+            : start_key {partition_block, -1}, end_key {partition_block, -1} {}
 };
 
 class VOlapTablePartKeyComparator {

be/src/exprs/bitmapfilter_predicate.h

@@ -33,7 +33,7 @@ class BitmapFilterFuncBase {
     virtual void insert_many(const std::vector<const BitmapValue*> bitmaps) = 0;
     virtual bool empty() = 0;
     virtual Status assign(BitmapValue* bitmap_value) = 0;
-    virtual void light_copy(BitmapFilterFuncBase* other) { _not_in = other->_not_in; };
+    virtual void light_copy(BitmapFilterFuncBase* other) { _not_in = other->_not_in; }
     virtual uint16_t find_fixed_len_olap_engine(const char* data, const uint8* nullmap,
                                                 uint16_t* offsets, int number) = 0;
     virtual void find_batch(const char* data, const uint8* nullmap, int number,

be/src/exprs/create_predicate_function.h

@@ -33,7 +33,7 @@ class MinmaxFunctionTraits {
     template <PrimitiveType type>
     static BasePtr get_function() {
         return new MinMaxNumFunc<typename PrimitiveTypeTraits<type>::CppType>();
-    };
+    }
 };
 
 class HybridSetTraits {
@@ -45,7 +45,7 @@ class HybridSetTraits {
         using Set =
                 std::conditional_t<std::is_same_v<CppType, StringRef>, StringSet, HybridSet<type>>;
         return new Set();
-    };
+    }
 };
 
 class BloomFilterTraits {
@@ -54,7 +54,7 @@ class BloomFilterTraits {
     template <PrimitiveType type>
     static BasePtr get_function() {
         return new BloomFilterFunc<type>();
-    };
+    }
 };
 
 class BitmapFilterTraits {
@@ -63,7 +63,7 @@ class BitmapFilterTraits {
     template <PrimitiveType type>
     static BasePtr get_function() {
         return new BitmapFilterFunc<type>();
-    };
+    }
 };
 
 template <class Traits>