address copilot review

Author: wrlcke

be/src/exprs/aggregate/aggregate_function_entropy.cpp

@@ -37,7 +37,7 @@ AggregateFunctionPtr create_aggregate_function_entropy(const std::string& name,
                 TYPE_BOOLEAN, TYPE_TINYINT, TYPE_SMALLINT, TYPE_INT, TYPE_BIGINT, TYPE_LARGEINT,
                 TYPE_DECIMAL32, TYPE_DECIMAL64, TYPE_DECIMAL128I, TYPE_DECIMAL256, TYPE_DECIMALV2,
                 TYPE_FLOAT, TYPE_DOUBLE, TYPE_DATE, TYPE_DATETIME, TYPE_DATEV2, TYPE_DATETIMEV2,
-                TYPE_TIME, TYPE_TIMEV2, TYPE_TIMESTAMPTZ>::
+                TYPE_TIME, TYPE_TIMEV2, TYPE_TIMESTAMPTZ, TYPE_IPV4, TYPE_IPV6>::
                 create<AggregateFunctionEntropy, AggregateFunctionEntropySingleNumericData>(
                         argument_types, result_is_nullable, attr);
         if (res) {

be/test/exprs/aggregate/agg_entropy_test.cpp

@@ -102,14 +102,25 @@ TEST_F(AggregateFunctionEntropyTest, test_nullable_entropy) {
 // ------------------------------------------------------------
 // 5. Empty input test
 // ------------------------------------------------------------
-TEST_F(AggregateFunctionEntropyTest, test_empty) {
+TEST_F(AggregateFunctionEntropyTest, test_empty_1) {
     create_agg("entropy", false, {std::make_shared<DataTypeInt32>()},
                std::make_shared<DataTypeFloat64>());
 
     Block block = ColumnHelper::create_block<DataTypeInt32>({});
 
-    // entropy of empty set = 0
+    // entropy of non-nullable empty set is 0
     execute(block, ColumnHelper::create_column_with_name<DataTypeFloat64>({0.0}));
 }
 
+TEST_F(AggregateFunctionEntropyTest, test_empty_2) {
+    create_agg("entropy", true,
+               {std::make_shared<DataTypeNullable>(std::make_shared<DataTypeInt32>())},
+               std::make_shared<DataTypeFloat64>());
+
+    Block block = ColumnHelper::create_nullable_block<DataTypeInt32>({}, {});
+
+    // entropy of nullable empty set is null
+    execute(block, ColumnHelper::create_nullable_column_with_name<DataTypeFloat64>({0.0}, {1}));
+}
+
 } // namespace doris

fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/Entropy.java

@@ -44,11 +44,11 @@ public Entropy(boolean distinct, Expression arg0, Expression... varArgs) {
     }
 
     public Entropy(boolean distinct, boolean alwaysNullable, Expression arg0, Expression... varArgs) {
-        this(distinct, alwaysNullable, false, ExpressionUtils.mergeArguments(arg0, varArgs));
+        this(distinct, alwaysNullable, ExpressionUtils.mergeArguments(arg0, varArgs));
     }
 
-    private Entropy(boolean distinct, boolean alwaysNullable, boolean isSkew, List<Expression> expressions) {
-        super("entropy", distinct, alwaysNullable, isSkew, expressions);
+    private Entropy(boolean distinct, boolean alwaysNullable, List<Expression> expressions) {
+        super("entropy", distinct, alwaysNullable, expressions);
     }
 
     private Entropy(NullableAggregateFunctionParams functionParams) {