test: changed test approach for mockito v3 - refactor v1

Author: iaorekhov-1980

fe/fe-core/src/test/java/org/apache/doris/mysql/privilege/PlainAuthWithEmptyPasswordAndLdapTest.java

@@ -37,21 +37,8 @@ public class PlainAuthWithEmptyPasswordAndLdapTest extends TestWithFeService {
     private LdapManager ldapManager = Mockito.mock(LdapManager.class);
     private MockedStatic<Env> mockedEnv;
 
-    private void setLdapUserExist(boolean res) {
-        Mockito.when(ldapManager.doesUserExist(Mockito.anyString())).thenReturn(res);
-    }
-
-    private void setCheckPassword(boolean res) {
-        Mockito.when(ldapManager.checkUserPasswd(
-            Mockito.anyString(), Mockito.anyString(),
-            Mockito.anyString(), Mockito.any())).thenReturn(res);
-    }
-
     @Test
     public void testPlainPasswordAuthWithAllowEmptyPassDefault() throws Exception {
-        setLdapUserExist(true);
-        setCheckPassword(true);
-
         //running test with non-specified value - ldap_allow_empty_pass should be true
         //non empty pass - success
         Assertions.assertTrue(LdapConfig.ldap_allow_empty_pass);
@@ -64,9 +51,6 @@ public void testPlainPasswordAuthWithAllowEmptyPassDefault() throws Exception {
 
     @Test
     public void testPlainPasswordAuthWithAllowEmptyPassTrue() throws Exception {
-        setLdapUserExist(true);
-        setCheckPassword(true);
-
         //running test with specified value - ldap_allow_empty_pass is be true
         LdapConfig.ldap_allow_empty_pass = true;
 
@@ -80,9 +64,6 @@ public void testPlainPasswordAuthWithAllowEmptyPassTrue() throws Exception {
 
     @Test
     public void testPlainPasswordAuthWithAllowEmptyPassFalse() throws Exception {
-        setLdapUserExist(true);
-        setCheckPassword(true);
-
         //running test with specified value - ldap_allow_empty_pass is false
         LdapConfig.ldap_allow_empty_pass = false;
 
@@ -107,19 +88,18 @@ public void tearDown() {
     @BeforeEach
     public void setUp() {
         LdapConfig.ldap_allow_empty_pass = true; // restoring default value for other tests
-    }
-
-    @Override
-    protected void runBeforeAll() throws Exception {
-        System.out.println("5.0 [" + LdapConfig.ldap_allow_empty_pass + "]");
-        LdapConfig.ldap_allow_empty_pass = true; //restoring default value for other tests
-
         Auth realAuth = Env.getCurrentEnv().getAuth();
 
         mockedEnv = Mockito.mockStatic(Env.class);
         Env mockedEnvInstance = Mockito.mock(Env.class);
 
         Auth authSpy = Mockito.spy(realAuth);
+
+        Mockito.when(ldapManager.doesUserExist(Mockito.anyString())).thenReturn(true);
+        Mockito.when(ldapManager.checkUserPasswd(
+            Mockito.anyString(), Mockito.anyString(),
+            Mockito.anyString(), Mockito.any())).thenReturn(true);
+
         Mockito.when(authSpy.getLdapManager()).thenReturn(ldapManager);
 
         Mockito.when(mockedEnvInstance.getAuth()).thenReturn(authSpy);