Commit d3c5dcf
authored
[refactor](Expr) move Expr and its related class to fe-catalog module (#62440)
### What problem does this PR solve?
Problem Summary:
This pull request makes several important changes to the `fe-catalog`
module, primarily focused on dependency management, build configuration,
and refactoring code from `fe-core` to `fe-catalog`. The changes also
simplify exception messages and update method signatures for better
clarity and maintainability.
**Dependency and Build Configuration Updates:**
* Added new dependencies to `fe-catalog/pom.xml`, including
`fe-foundation`, `fe-type`, `commons-collections4`, and
`antlr4-runtime`, to support parsing and type utilities.
* Introduced the `antlr4-maven-plugin` to the build plugins in `pom.xml`
for automatic ANTLR grammar processing during the build.
**Code Refactoring and Cleanup:**
* Moved several analysis classes (`CompoundPredicate`, `DecimalLiteral`,
`EncryptKeyName`) from `fe-core` to `fe-catalog`, and updated their
package references accordingly.
[[1]](diffhunk://#diff-948d0b0d5c53081ca071883defe825b2e61237bd06a9ed74c2dde034fc47ea36L112-R116)
[[2]](diffhunk://#diff-aadad556e434b3d4f441ea9a15daddc5e021934d2d3a61629029cc8a4b056f8bL188-R188)
[[3]](diffhunk://#diff-8fde91d35b6b3c4a25cdae6a87af1a7f955148dc79321ff349a0b97f753fa783L21-L24)
**Code Simplification and Error Handling Improvements:**
* Simplified exception messages in `DecimalLiteral` and
`CompoundPredicate` by removing the use of `ExprToSqlVisitor` and
instead using the object's `toString()` representation.
[[1]](diffhunk://#diff-948d0b0d5c53081ca071883defe825b2e61237bd06a9ed74c2dde034fc47ea36L112-R116)
[[2]](diffhunk://#diff-aadad556e434b3d4f441ea9a15daddc5e021934d2d3a61629029cc8a4b056f8bL188-R188)
* Changed the `analyze` method in `EncryptKeyName` to accept a `String
defaultDb` instead of a `ConnectContext`, and replaced usage of
`ErrorReport` with direct exception throwing for missing database
selection.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [x] No need to test or manual test. Explain why:
- [x] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->1 parent 52a0fdf commit d3c5dcf
File tree
279 files changed
+1230
-865
lines changed- fe
- fe-catalog
- src/main
- antlr4/org/apache/doris/analysis
- java/org/apache/doris
- analysis
- catalog
- info
- persist/gson
- fe-common/src/main/java/org/apache/doris
- common
- persist/gson
- fe-core/src
- main/java/org/apache/doris
- alter
- analysis
- backup
- catalog
- constraint
- cloud/datasource
- datasource
- hive
- info
- job/extensions/mtmv
- load
- mtmv
- mysql/privilege
- nereids
- load
- parser
- rules/rewrite
- stats
- trees/plans
- commands
- execute
- info
- load
- refresh
- logical
- physical
- util
- persist
- gson
- planner
- qe
- service
- statistics
- util
- tablefunction
- task
- test/java/org/apache/doris
- alter
- analysis
- backup
- catalog
- constraint
- common/proc
- datasource
- hive
- iceberg
- lakesoul
- trinoconnector
- info
- load/loadv2
- mtmv
- nereids/trees/plans
- commands
- persist/gson
- planner
- qe
- statistics
- utframe
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
279 files changed
+1230
-865
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
36 | 41 | | |
37 | 42 | | |
38 | 43 | | |
39 | 44 | | |
40 | 45 | | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
41 | 61 | | |
42 | 62 | | |
43 | 63 | | |
| |||
51 | 71 | | |
52 | 72 | | |
53 | 73 | | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
54 | 94 | | |
55 | 95 | | |
56 | 96 | | |
| |||
0 commit comments