[Fix](udf) mark udf nondeterministic

linrrzqqq · linrrzqqq · commit f2edf4314889 · 2026-04-22T14:36:13.000+08:00
diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/udf/JavaUdaf.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/udf/JavaUdaf.java
@@ -114,6 +114,11 @@ public NullableMode getNullableMode() {
         return nullableMode;
     }
 
+    @Override
+    public boolean isDeterministic() {
+        return false;
+    }
+
     /**
      * withChildren.
      */
diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/udf/JavaUdf.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/udf/JavaUdf.java
@@ -99,6 +99,11 @@ public NullableMode getNullableMode() {
         return nullableMode;
     }
 
+    @Override
+    public boolean isDeterministic() {
+        return false;
+    }
+
     /**
      * withChildren.
      */
diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/udf/JavaUdtf.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/udf/JavaUdtf.java
@@ -95,6 +95,11 @@ public List<FunctionSignature> getSignatures() {
         return ImmutableList.of(signature);
     }
 
+    @Override
+    public boolean isDeterministic() {
+        return false;
+    }
+
     @Override
     public boolean hasVarArguments() {
         return signature.hasVarArgs;
diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/udf/PythonUdaf.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/udf/PythonUdaf.java
@@ -119,6 +119,11 @@ public NullableMode getNullableMode() {
         return nullableMode;
     }
 
+    @Override
+    public boolean isDeterministic() {
+        return false;
+    }
+
     /**
      * withChildren.
      */
diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/udf/PythonUdf.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/udf/PythonUdf.java
@@ -104,6 +104,11 @@ public NullableMode getNullableMode() {
         return nullableMode;
     }
 
+    @Override
+    public boolean isDeterministic() {
+        return false;
+    }
+
     /**
      * withChildren.
      */
diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/udf/PythonUdtf.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/udf/PythonUdtf.java
@@ -100,6 +100,11 @@ public List<FunctionSignature> getSignatures() {
         return ImmutableList.of(signature);
     }
 
+    @Override
+    public boolean isDeterministic() {
+        return false;
+    }
+
     @Override
     public boolean hasVarArguments() {
         return signature.hasVarArgs;
diff --git a/regression-test/data/pythonudaf_p0/test_pythonudaf_nondeterministic.out b/regression-test/data/pythonudaf_p0/test_pythonudaf_nondeterministic.out
@@ -0,0 +1,11 @@
+-- This file is automatically generated. You should know what you did if you want to edit this
+-- !materialized --
+1	1
+2	1
+3	1
+
+-- !inlined --
+1	1
+2	1
+3	1
+
diff --git a/regression-test/data/pythonudf_p0/test_pythonudf_float.out b/regression-test/data/pythonudf_p0/test_pythonudf_float.out
@@ -15,11 +15,6 @@
 112	1012334.0
 113	\N
 
--- !select --
-111	-211111.2
-112	1012334.0
-113	\N
-
 -- !select --
 113.9475611
 
@@ -30,4 +25,3 @@
 111	24691356.68911354
 112	444444444.6666667
 113	13333333333.33333
-
diff --git a/regression-test/data/pythonudf_p0/test_pythonudf_nondeterministic.out b/regression-test/data/pythonudf_p0/test_pythonudf_nondeterministic.out
@@ -0,0 +1,10 @@
+-- This file is automatically generated. You should know what you did if you want to edit this
+-- !materialized --
+1	1
+2	1
+3	1
+
+-- !inlined --
+1	1
+2	1
+3	1
diff --git a/regression-test/data/pythonudtf_p0/test_pythonudtf_nondeterministic.out b/regression-test/data/pythonudtf_p0/test_pythonudtf_nondeterministic.out
@@ -0,0 +1,11 @@
+-- This file is automatically generated. You should know what you did if you want to edit this
+-- !materialized --
+1	1
+2	1
+3	1
+
+-- !inlined --
+1	1
+2	1
+3	1
+
diff --git a/regression-test/suites/pythonudaf_p0/test_pythonudaf_nondeterministic.groovy b/regression-test/suites/pythonudaf_p0/test_pythonudaf_nondeterministic.groovy
@@ -0,0 +1,138 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import org.junit.Assert;
+
+suite("test_pythonudaf_nondeterministic") {
+    def runtime_version = getPythonUdfRuntimeVersion()
+
+    try {
+        sql """ DROP TABLE IF EXISTS cte_uuid_seed; """
+        sql """ DROP TABLE IF EXISTS mtmv_uuid_seed; """
+        sql """ DROP MATERIALIZED VIEW IF EXISTS py_uuid_agg_mtmv; """
+        sql """
+        CREATE TABLE cte_uuid_seed (id INT) ENGINE=OLAP DUPLICATE KEY(id)
+        DISTRIBUTED BY HASH(id) BUCKETS 1
+        PROPERTIES ("replication_num" = "1");
+        """
+        sql """ INSERT INTO cte_uuid_seed VALUES (1), (2), (3); """
+        sql """ sync; """
+
+        sql """ SET enable_nereids_planner = true; """
+        sql """ SET enable_fallback_to_original_planner = false; """
+
+        sql """ DROP FUNCTION IF EXISTS py_uuid_agg(INT); """
+        sql """
+        CREATE AGGREGATE FUNCTION py_uuid_agg(INT)
+        RETURNS STRING
+        PROPERTIES (
+            "type" = "PYTHON_UDF",
+            "symbol" = "PyUuidAgg",
+            "always_nullable" = "false",
+            "runtime_version" = "${runtime_version}"
+        )
+        AS \$\$
+import uuid
+
+class PyUuidAgg:
+    def __init__(self):
+        self.last = None
+
+    def accumulate(self, value):
+        if value is not None:
+            self.last = value
+
+    def merge(self, other_state):
+        if other_state is not None:
+            self.last = other_state
+
+    def finish(self):
+        return f"{self.last}-{uuid.uuid4()}"
+
+    @property
+    def aggregate_state(self):
+        return self.last
+\$\$;
+        """
+
+        sql """ SET enable_cte_materialize = true; """
+        sql """ SET inline_cte_referenced_threshold = 1; """
+        qt_materialized """
+        WITH cte AS (
+            SELECT id, py_uuid_agg(id) AS token
+            FROM cte_uuid_seed
+            GROUP BY id
+        )
+        SELECT id, COUNT(DISTINCT token) AS distinct_tokens
+        FROM (
+            SELECT id, token FROM cte
+            UNION ALL
+            SELECT id, token FROM cte
+        ) u
+        GROUP BY id
+        ORDER BY id;
+        """
+
+        sql """ SET enable_cte_materialize = true; """
+        sql """ SET inline_cte_referenced_threshold = 10; """
+        qt_inlined """
+        WITH cte AS (
+            SELECT id, py_uuid_agg(id) AS token
+            FROM cte_uuid_seed
+            GROUP BY id
+        )
+        SELECT id, COUNT(DISTINCT token) AS distinct_tokens
+        FROM (
+            SELECT id, token FROM cte
+            UNION ALL
+            SELECT id, token FROM cte
+        ) u
+        GROUP BY id
+        ORDER BY id;
+        """
+
+        sql """
+        CREATE TABLE mtmv_uuid_seed (id INT, v INT) ENGINE=OLAP DUPLICATE KEY(id)
+        DISTRIBUTED BY HASH(id) BUCKETS 1
+        PROPERTIES ("replication_num" = "1");
+        """
+        sql """ INSERT INTO mtmv_uuid_seed VALUES (1, 10), (1, 11), (2, 20), (2, 21), (3, 30), (3, 31); """
+        sql """ sync; """
+
+        try {
+            sql """
+            CREATE MATERIALIZED VIEW py_uuid_agg_mtmv
+            BUILD DEFERRED REFRESH COMPLETE ON MANUAL
+            DISTRIBUTED BY HASH(`id`) BUCKETS 1
+            PROPERTIES ("replication_num" = "1")
+            AS
+            SELECT id, py_uuid_agg(v) AS token
+            FROM mtmv_uuid_seed
+            GROUP BY id;
+            """
+            Assert.fail()
+        } catch (Exception e) {
+            log.info(e.getMessage())
+            assertTrue(e.getMessage().contains("can not contain nonDeterministic expression"))
+        }
+    } finally {
+        try_sql(""" DROP MATERIALIZED VIEW IF EXISTS py_uuid_agg_mtmv; """)
+        sql """ DROP FUNCTION IF EXISTS py_uuid_agg(INT); """
+        sql """ DROP TABLE IF EXISTS cte_uuid_seed; """
+        sql """ DROP TABLE IF EXISTS mtmv_uuid_seed; """
+    }
+}
diff --git a/regression-test/suites/pythonudf_p0/test_pythonudf_float.groovy b/regression-test/suites/pythonudf_p0/test_pythonudf_float.groovy
@@ -59,13 +59,6 @@ suite("test_pythonudf_float") {
         qt_select """ SELECT python_udf_float_test(cast(2.83645 as float),cast(111.1111111 as float)) as result; """
         qt_select """ SELECT python_udf_float_test(2.83645,111.1111111) as result ; """
         qt_select """ SELECT user_id,python_udf_float_test(float_1, float_2) as sum FROM test_pythonudf_float order by user_id; """
-        createMV("create materialized view udf_mv as SELECT user_id as a1,python_udf_float_test(float_1, float_2) as sum FROM test_pythonudf_float order by user_id;")
-        qt_select """ SELECT user_id,python_udf_float_test(float_1, float_2) as sum FROM test_pythonudf_float order by user_id; """
-
-        explain {
-            sql("SELECT user_id,python_udf_float_test(float_1, float_2) as sum FROM test_pythonudf_float order by user_id; ")
-            contains "(udf_mv)"
-        }
 
         sql """ CREATE FUNCTION python_udf_double_test(DOUBLE,DOUBLE) RETURNS DOUBLE PROPERTIES (
             "file"="file://${pyPath}",
@@ -80,6 +73,7 @@ suite("test_pythonudf_float") {
         qt_select """ SELECT user_id,python_udf_double_test(double_1, double_1) as sum FROM test_pythonudf_float order by user_id; """
 
     } finally {
+        try_sql("DROP MATERIALIZED VIEW IF EXISTS udf_mv;")
         try_sql("DROP FUNCTION IF EXISTS python_udf_double_test(DOUBLE,DOUBLE);")
         try_sql("DROP FUNCTION IF EXISTS python_udf_float_test(FLOAT,FLOAT);")
         try_sql("DROP TABLE IF EXISTS test_pythonudf_float")
diff --git a/regression-test/suites/pythonudf_p0/test_pythonudf_nondeterministic.groovy b/regression-test/suites/pythonudf_p0/test_pythonudf_nondeterministic.groovy
diff --git a/regression-test/suites/pythonudtf_p0/test_pythonudtf_nondeterministic.groovy b/regression-test/suites/pythonudtf_p0/test_pythonudtf_nondeterministic.groovy
diff --git a/regression-test/suites/query_p0/javaudf/test_javaudf_nondeterministic.groovy b/regression-test/suites/query_p0/javaudf/test_javaudf_nondeterministic.groovy
