Skip to content

Commit f6a4f02

Browse files
authored
[chore](beut) fix beut use assume_mutable (#63598)
### What problem does this PR solve? Related PR: #63386 now use assert_mutable
1 parent 3484698 commit f6a4f02

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

be/benchmark/benchmark_column_array_view.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ static ColumnPtr make_string_array_column() {
126126

127127
// Wrap with outer Nullable (no rows are actually null, just the wrapper overhead).
128128
static ColumnPtr wrap_nullable(const ColumnPtr& col) {
129-
return ColumnNullable::create(col->assume_mutable(),
129+
return ColumnNullable::create(col->assert_mutable(),
130130
ColumnUInt8::create(col->size(), 0));
131131
}
132132

be/benchmark/benchmark_column_array_view_distance.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ BENCHMARK(ArrayView_Distance_Const_Plain_Flat)->Unit(benchmark::kNanosecond);
264264
// ============================================================
265265

266266
static ColumnPtr wrap_nullable_for_dist(const ColumnPtr& col) {
267-
return ColumnNullable::create(col->assume_mutable(), ColumnUInt8::create(col->size(), 0));
267+
return ColumnNullable::create(col->assert_mutable(), ColumnUInt8::create(col->size(), 0));
268268
}
269269

270270
static void Handwritten_Distance_Nullable_Plain(benchmark::State& state) {

be/test/core/column/column_array_view_test.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@ static ColumnPtr build_int32_array_column(const std::vector<std::vector<int32_t>
6666
for (auto v : row_nulls) {
6767
outer_null->insert_value(v);
6868
}
69-
array_col = ColumnNullable::create(array_col->assume_mutable(), std::move(outer_null));
69+
ColumnPtr outer_null_col = std::move(outer_null);
70+
array_col = ColumnNullable::create(array_col, outer_null_col);
7071
}
7172
return array_col;
7273
}
@@ -101,7 +102,8 @@ static ColumnPtr build_string_array_column(const std::vector<std::vector<std::st
101102
for (auto v : row_nulls) {
102103
outer_null->insert_value(v);
103104
}
104-
array_col = ColumnNullable::create(array_col->assume_mutable(), std::move(outer_null));
105+
ColumnPtr outer_null_col = std::move(outer_null);
106+
array_col = ColumnNullable::create(array_col, outer_null_col);
105107
}
106108
return array_col;
107109
}

0 commit comments

Comments
 (0)