Skip to content

[fix](insert) Avoid formatting generated insert errors#62982

Open
foxtail463 wants to merge 1 commit intoapache:masterfrom
foxtail463:fix-insert-unhealthy-backend-error-format
Open

[fix](insert) Avoid formatting generated insert errors#62982
foxtail463 wants to merge 1 commit intoapache:masterfrom
foxtail463:fix-insert-unhealthy-backend-error-format

Conversation

@foxtail463
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Problem Summary:

The unhealthy-backend insert failure path passed a generated error message as the String.format pattern to ErrorReport. If the generated message contains percent signs, reporting can throw a secondary formatting exception and hide the original insert failure. Use a fixed "%s" pattern and pass the generated message as data.

@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@foxtail463
Copy link
Copy Markdown
Contributor Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants