[fix](test) Fix flaky assertion in test_streaming_insert_job_fetch_meta_error#62499
Open
JNSimba wants to merge 1 commit intoapache:masterfrom
Open
[fix](test) Fix flaky assertion in test_streaming_insert_job_fetch_meta_error#62499JNSimba wants to merge 1 commit intoapache:masterfrom
JNSimba wants to merge 1 commit intoapache:masterfrom
Conversation
…ta_error Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
PR #62023 refactored the filesystem SPI, which changed the error propagation path in
S3SourceOffsetProvider.fetchRemoteMeta().Previously (#61284), the debug point created a
GlobListResultwith an error status, and the subsequent status check threw an exception with message"Failed to list S3 files: ...". After the refactoring in #62023, the debug point was changed to directly throw anIOException, which is caught byStreamingInsertJob.fetchMeta()and wrapped as"Failed to fetch meta, ...". However, the regression test assertion was not updated accordingly, causing the test to fail intermittently.How does this PR fix it?
Update the assertion in
test_streaming_insert_job_fetch_meta_errorfrom checking"Failed to list S3 files"to"Failed to fetch meta", matching the actual error message produced by the current code path.Release note
None
Check List (For Author)
Check List (For Reviewer who is not the Author)