[fix](storage) Fix linker error for SegmentWriter::_is_mow() with -O1/-O3#63928
Merged
yiguolei merged 1 commit intoJun 9, 2026
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
1 task
Contributor
Author
|
run buildall |
heguanhui
force-pushed
the
fix/segment-writer-inline-linker-error
branch
from
690328a to
804c31c
Compare
yiguolei
previously approved these changes
Jun 1, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
run buildall |
Contributor
TPC-H: Total hot run time: 29263 ms |
Contributor
TPC-DS: Total hot run time: 170825 ms |
heguanhui
force-pushed
the
fix/segment-writer-inline-linker-error
branch
from
804c31c to
04717d8
Compare
github-actions
Bot
removed
the
approved
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 28727 ms |
Contributor
TPC-DS: Total hot run time: 170738 ms |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
Contributor
Author
|
/review |
Contributor
TPC-H: Total hot run time: 29389 ms |
Contributor
TPC-DS: Total hot run time: 169461 ms |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
heguanhui
force-pushed
the
fix/segment-writer-inline-linker-error
branch
2 times, most recently
from
1c35ec3 to
96f1ab1
Compare
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 28971 ms |
Contributor
TPC-DS: Total hot run time: 169143 ms |
heguanhui
force-pushed
the
fix/segment-writer-inline-linker-error
branch
2 times, most recently
from
ce47654 to
3369788
Compare
Contributor
Author
|
run buildall |
heguanhui
force-pushed
the
fix/segment-writer-inline-linker-error
branch
from
3369788 to
77cacdb
Compare
Contributor
Author
|
run buildall |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
TPC-H: Total hot run time: 29465 ms |
Contributor
TPC-DS: Total hot run time: 169275 ms |
yiguolei
approved these changes
Jun 9, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code review completed. I did not find blocking issues in this PR.
Critical checkpoint conclusions:
- Goal and tests: The PR addresses the O1/O3 linker failure by moving the helper definitions into the headers where cross-translation-unit callers can see inline definitions. The new BE unit test is included by the existing recursive BE test glob and covers MOW true/false and cluster-key cases for both segment writer classes.
- Scope: The implementation change is small and focused; it only relocates helper definitions and adds a targeted linker-regression test.
- Concurrency: No new concurrency or shared mutable state is introduced.
- Lifecycle/static initialization: No new static initialization dependency was introduced. The test directory constant is local to the test translation unit and does not affect production lifecycle.
- Configuration/compatibility: No new configuration, storage format, RPC, or FE-BE protocol compatibility impact.
- Parallel code paths: Both SegmentWriter and VerticalSegmentWriter are updated consistently.
- Error handling/status: Production error handling is unchanged; the test checks filesystem setup statuses before use.
- Test coverage: Coverage is appropriate for this linker/inline-definition regression. I did not run the BE unit test locally because no BE test binary/build output is available in this runner.
- Observability: Not applicable for this compile/link-only fix.
- Transaction/data correctness: Not applicable; no data visibility, version, rowset lifecycle, or delete bitmap behavior changes.
- Performance/memory: No meaningful runtime performance or memory-accounting risk introduced; helpers are simple predicates that were already intended to be inline-capable.
User focus points: No additional user-provided review focus was specified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #63927
Problem Summary: Building BE unit tests with TSAN (
-O1) or RELEASE (-O3) causes undefined reference linker errors forSegmentWriter::_is_mow(),SegmentWriter::_is_mow_with_cluster_key(), and theirVerticalSegmentWritercounterparts.Root cause: Commit
74aa0ca63adefined these methods with theinlinekeyword in.cppfiles (segment_writer.cppandvertical_segment_writer.cpp). At-O0(ASAN), the compiler ignoresinlineand exports the symbol, so linking succeeds. At-O1/-O3, the compiler inlines the function and does NOT export the symbol. When commit4616202fc4introducedTestSegmentWriter(a friend subclass) intest_segment_writer.hthat calls these private methods from a different translation unit, the linker cannot find the symbols.Fix: Move the
inlinedefinitions from.cppfiles into the header files as class-internal inline definitions, so they are visible to all translation units.Error example (TSAN build):
Release note
None
Check List (For Author)
Test
segment_writer_mow_check_test.cppwith 7 test cases covering all logic branches for bothSegmentWriterandVerticalSegmentWriterBehavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)