Skip to content

[fix](nereids) do not use mv that requires union when union rewrite i…#64207

Draft
yx-keith wants to merge 1 commit into
apache:masterfrom
yx-keith:fix-mv-union-rewrite-flag-59593
Draft

[fix](nereids) do not use mv that requires union when union rewrite i…#64207
yx-keith wants to merge 1 commit into
apache:masterfrom
yx-keith:fix-mv-union-rewrite-flag-59593

Conversation

@yx-keith
Copy link
Copy Markdown
Contributor

@yx-keith yx-keith commented Jun 8, 2026

…s disabled (#59593)

When a partitioned mv misses some queried partitions, union compensation with the base table is required to produce a complete result. The partition-compensation branch was gated by enable_materialized_view_union_rewrite, so when that flag was false the whole branch was skipped and the partial mv-only plan was used as the rewrite result, silently dropping the rows of the uncovered partitions.

Compute the invalid partitions regardless of the flag, and bail out (the mv can not be used for this query) when the mv actually needs union compensation but union rewrite is disabled - same handling as when union compensation can not be done because of the query structInfo. When the mv covers all queried partitions (no union needed) the mv is still used as before, so the flag only affects mvs that genuinely require union.

Add a regression test that, with the flag off and an mv missing a base-table partition, asserts the mv is not chosen and the query still returns the complete result.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…s disabled (apache#59593)

When a partitioned mv misses some queried partitions, union compensation with the
base table is required to produce a complete result. The partition-compensation
branch was gated by enable_materialized_view_union_rewrite, so when that flag was
false the whole branch was skipped and the partial mv-only plan was used as the
rewrite result, silently dropping the rows of the uncovered partitions.

Compute the invalid partitions regardless of the flag, and bail out (the mv can not
be used for this query) when the mv actually needs union compensation but union
rewrite is disabled - same handling as when union compensation can not be done
because of the query structInfo. When the mv covers all queried partitions
(no union needed) the mv is still used as before, so the flag only affects mvs that
genuinely require union.

Add a regression test that, with the flag off and an mv missing a base-table
partition, asserts the mv is not chosen and the query still returns the complete
result.
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yx-keith yx-keith marked this pull request as draft June 8, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants