Skip to content

Fix DateFormat in DateGen.java#2959

Merged
cgivre merged 2 commits intomasterfrom
pjfanning-patch-2
Mar 13, 2025
Merged

Fix DateFormat in DateGen.java#2959
cgivre merged 2 commits intomasterfrom
pjfanning-patch-2

Conversation

@pjfanning
Copy link
Copy Markdown
Member

@pjfanning pjfanning commented Oct 26, 2024 •
edited
Loading

See #2958

pjfanning
pjfanning commented Oct 26, 2024
View reviewed changes
Comment thread exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/DateGen.java Outdated
long randTime = baseTime + baseTime + rand.nextInt(365) * ONE_DAY;
String str = fmt.format(new Date(randTime));
colWriter.setString(str);
final long randTime = baseTime + baseTime + rand.nextInt(365) * ONE_DAY;
Copy link
Copy Markdown
Member Author

@pjfanning pjfanning Oct 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnturton @cgivre this doesn't look right - baseTime is a big number but we add it twice so the result will be a very big number, a long way in the future.

Copy link
Copy Markdown
Contributor

@cgivre cgivre Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjfanning What if you just make it:

long randTime = baseTime + (rand.nextInt(365)* ONE_DAY)

@pjfanning pjfanning marked this pull request as draft October 27, 2024 00:49
cgivre
cgivre requested changes Mar 12, 2025
View reviewed changes
Comment thread exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/DateGen.java Outdated
long randTime = baseTime + baseTime + rand.nextInt(365) * ONE_DAY;
String str = fmt.format(new Date(randTime));
colWriter.setString(str);
final long randTime = baseTime + baseTime + rand.nextInt(365) * ONE_DAY;
Copy link
Copy Markdown
Contributor

@cgivre cgivre Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjfanning What if you just make it:

long randTime = baseTime + (rand.nextInt(365)* ONE_DAY)

@pjfanning pjfanning changed the title [DRAFT] Fix DateFormat in DateGen.java Fix DateFormat in DateGen.java Mar 13, 2025
@pjfanning pjfanning marked this pull request as ready for review March 13, 2025 13:44
@pjfanning
Copy link
Copy Markdown
Member Author

pjfanning commented Mar 13, 2025

@cgivre I made the change to the randTime calculation

cgivre
cgivre approved these changes Mar 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@cgivre cgivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@cgivre cgivre merged commit d5358d6 into master Mar 13, 2025
13 checks passed
@pjfanning pjfanning mentioned this pull request Mar 13, 2025
Closed
cgivre pushed a commit to cgivre/drill that referenced this pull request May 7, 2025
@pjfanning @cgivre
Fix DateFormat in DateGen.java (apache#2959)
178a9dd
cgivre pushed a commit to cgivre/drill that referenced this pull request Mar 25, 2026
@pjfanning
Fix DateFormat in DateGen.java (apache#2959)
5a0e567
@pjfanning pjfanning deleted the pjfanning-patch-2 branch April 20, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgivre cgivre cgivre approved these changes

Assignees

@pjfanning pjfanning

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pjfanning @cgivre