DRILL-8522: Change session cookie name. Use STRICT sameSite#2985
Merged
rymarm merged 1 commit intoapache:masterfrom May 8, 2025
Merged
DRILL-8522: Change session cookie name. Use STRICT sameSite#2985rymarm merged 1 commit intoapache:masterfrom
rymarm merged 1 commit intoapache:masterfrom
Conversation
cgivre
approved these changes
May 8, 2025
Contributor
cgivre
left a comment
cgivre
left a comment
There was a problem hiding this comment.
LGTM +1. Please rebase on current master so we can get a clean CI run and then we can merge.
cgivre
pushed a commit
to cgivre/drill
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRILL-8522: Change session cookie name. Use STRICT sameSite
Drill uses Jetty's default cookie name,
JSESSIONID, to store the user session ID.Because
JSESSIONIDis a generic name, multiple web services running on the same host can conflict if they use the same cookie name.Description
Instead of the generic
JSESSIONIDcookie name, Drill will now useDrill-Session-Idfor HTTP and__Secure-Drill-Session-Idfor HTTPS. For HTTPS used__Secure-prefix to ensure the cookie is set from secure origin: https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/Cookies#cookie_prefixesAdditionally, the cookie's
sameSiteattribute is now set toSTRICTfor improved security. More info about this configuration you can find here: https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/Cookies#controlling_third-party_cookies_with_samesiteDocumentation
-
Testing
Manual tests