DRILL-8523: Remove Support for Java 8#2987
Merged
cgivre merged 12 commits intoapache:masterfrom May 8, 2025
Merged
Conversation
cgivre
added
code-cleanup
security
dependencies
backport-to-stable
jnturton
requested changes
May 7, 2025
| classLoader.injectByteCode(nextGenerated.dot, result.bytes); | ||
|
|
||
| // Only inject bytecode if not already injected | ||
| if (!injectedClassNames.contains(nextGenerated.dot)) { |
Contributor
There was a problem hiding this comment.
It's hard to tell from the diff what was broken here before. Was the namesCompleted Set not enough to keep track of classes that had already been merged?
Contributor
Author
There was a problem hiding this comment.
I'm not sure honestly. It seemed to break when I switched the Java version to 11 in the test suite.
jnturton
approved these changes
May 7, 2025
cgivre
added a commit
to cgivre/drill
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRILL-8523: Remove Support for Java 8
Description
This PR removes the CI actions for Java 8 and effectively ends Drill's support for Java 8. As a consequence of that, Drill no longer supports Hadoop 2. The profile is still in the pom.xml file should anyone want to build Drill for Hadoop 2, but we are no longer running CI with those tests.
This seems to have the added benefit of fixing the flaky Hive tests in the Hadoop-2 runs.
This PR also adds CI tests for Java 21.
Documentation
No user facing changes.
Testing
Ran existing unit tests.