DRILL-8524: Drill Adding Duplicate Parameters in Offset Paginator#2988
Merged
cgivre merged 2 commits intoapache:masterfrom May 8, 2025
Merged
DRILL-8524: Drill Adding Duplicate Parameters in Offset Paginator#2988cgivre merged 2 commits intoapache:masterfrom
cgivre merged 2 commits intoapache:masterfrom
Conversation
cgivre
added
bug
minor-update
backport-to-stable
cgivre
added a commit
to cgivre/drill
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRILL-8524: Drill Adding Duplicate Parameters in Offset Paginator
Description
This PR fixes a minor bug with the Offset paginator. When the URL params have a
$or other control character, the pagination was not properly updating the URL and adding duplicate parameters to the URL. This PR solves that.Additionally, this PR bumps OkHTTP to the latest version.
Documentation
No user facing changes.
Testing
Tested against user provided API. Ran existing unit tests.