DRILL-8525: Migrate Fully to Apache Commons Collections 4.x#2991
DRILL-8525: Migrate Fully to Apache Commons Collections 4.x#2991cgivre merged 5 commits intoapache:masterfrom
Conversation
cgivre
left a comment
There was a problem hiding this comment.
LGTM +1.
Thanks for catching this. I don't know if this would be out of scope for this PR, but would it make sense to bump the Hadoop version to the latest version, or is that a separate PR?
|
@cgivre At first, I wanted to bump Hadoop version, but then checked the release notes, and I think it will be better to double check it, and make changes to Drill if needed, like, for example, for this:
Let's do it in a separate PR. https://hadoop.apache.org/docs/r3.4.0/hadoop-project-dist/hadoop-common/release/3.4.0/RELEASENOTES.3.4.0.html |
DRILL-8525: Migrate Fully to Apache Commons Collections 4.x
Description
To my surprise, Drill still uses classes from commons-collections (
3.xrelease) in a few places, and Drill has not even declared it as a dependency. Drill used transitive dependency fromhadoop-commons:But starting from
3.4.2release, Hadoop drops it: https://issues.apache.org/jira/browse/HADOOP-15760Time to clean our code too and completely migrate to
4.x:)Documentation
No user-visible changes
Testing
Unit tests