style: fix checkstyle and forbidden-apis violations (imports, argument line breaking, DateTimes.utc, Maps.newHashMapWithExpectedSize)

Author: Shekharrajak

extensions-contrib/druid-iceberg-extensions/src/main/java/org/apache/druid/iceberg/input/IcebergArrowInputSourceReader.java

@@ -19,6 +19,7 @@
 
 package org.apache.druid.iceberg.input;
 
+import com.google.common.collect.Maps;
 import org.apache.arrow.vector.BigIntVector;
 import org.apache.arrow.vector.BitVector;
 import org.apache.arrow.vector.DateDayVector;
@@ -29,14 +30,14 @@
 import org.apache.arrow.vector.Float8Vector;
 import org.apache.arrow.vector.IntVector;
 import org.apache.arrow.vector.SmallIntVector;
+import org.apache.arrow.vector.TimeMicroVector;
 import org.apache.arrow.vector.TimeStampMicroTZVector;
 import org.apache.arrow.vector.TimeStampMicroVector;
-import org.apache.arrow.vector.TimeStampNanoTZVector;
-import org.apache.arrow.vector.TimeStampNanoVector;
 import org.apache.arrow.vector.TimeStampMilliTZVector;
 import org.apache.arrow.vector.TimeStampMilliVector;
+import org.apache.arrow.vector.TimeStampNanoTZVector;
+import org.apache.arrow.vector.TimeStampNanoVector;
 import org.apache.arrow.vector.TinyIntVector;
-import org.apache.arrow.vector.TimeMicroVector;
 import org.apache.arrow.vector.VarBinaryVector;
 import org.apache.arrow.vector.VarCharVector;
 import org.apache.druid.data.input.InputRow;
@@ -46,7 +47,6 @@
 import org.apache.druid.data.input.InputStats;
 import org.apache.druid.data.input.MapBasedInputRow;
 import org.apache.druid.iceberg.filter.IcebergFilter;
-import org.apache.druid.java.util.common.RE;
 import org.apache.druid.java.util.common.parsers.CloseableIterator;
 import org.apache.iceberg.CombinedScanTask;
 import org.apache.iceberg.Table;
@@ -61,7 +61,6 @@
 import java.io.IOException;
 import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
-import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.NoSuchElementException;
@@ -183,7 +182,7 @@ private TableScan buildScan()
   private InputRow batchRowToInputRow(final ColumnarBatch batch, final int rowIdx)
   {
     final int numCols = batch.numCols();
-    final Map<String, Object> event = new HashMap<>(numCols);
+    final Map<String, Object> event = Maps.newHashMapWithExpectedSize(numCols);
     for (int col = 0; col < numCols; col++) {
       final FieldVector vec = batch.column(col).getFieldVector();
       if (!vec.isNull(rowIdx)) {

extensions-contrib/druid-iceberg-extensions/src/test/java/org/apache/druid/iceberg/input/IcebergArrowInputSourceReaderTest.java

@@ -27,6 +27,7 @@
 import org.apache.druid.data.input.impl.StringDimensionSchema;
 import org.apache.druid.data.input.impl.TimestampSpec;
 import org.apache.druid.iceberg.filter.IcebergEqualsFilter;
+import org.apache.druid.java.util.common.DateTimes;
 import org.apache.druid.java.util.common.FileUtils;
 import org.apache.druid.java.util.common.parsers.CloseableIterator;
 import org.apache.iceberg.DataFile;
@@ -106,7 +107,12 @@ public void testBasicRead() throws IOException
     writeRows(table, row(1_000L, "alice", 1.1), row(2_000L, "bob", 2.2), row(3_000L, "carol", 3.3));
 
     final IcebergArrowInputSourceReader reader = new IcebergArrowInputSourceReader(
-        table, null, null, true, INPUT_SCHEMA, IcebergArrowInputSourceReader.DEFAULT_BATCH_SIZE
+        table,
+        null,
+        null,
+        true,
+        INPUT_SCHEMA,
+        IcebergArrowInputSourceReader.DEFAULT_BATCH_SIZE
     );
 
     final List<InputRow> rows = readAll(reader);
@@ -126,7 +132,12 @@ public void testEmptyTable() throws IOException
     final Table table = catalog.retrieveTable(NAMESPACE, TABLE);
 
     final IcebergArrowInputSourceReader reader = new IcebergArrowInputSourceReader(
-        table, null, null, true, INPUT_SCHEMA, IcebergArrowInputSourceReader.DEFAULT_BATCH_SIZE
+        table,
+        null,
+        null,
+        true,
+        INPUT_SCHEMA,
+        IcebergArrowInputSourceReader.DEFAULT_BATCH_SIZE
     );
 
     final List<InputRow> rows = readAll(reader);
@@ -175,7 +186,12 @@ public void testColumnPruning() throws IOException
     );
 
     final IcebergArrowInputSourceReader reader = new IcebergArrowInputSourceReader(
-        table, null, null, true, pruned, IcebergArrowInputSourceReader.DEFAULT_BATCH_SIZE
+        table,
+        null,
+        null,
+        true,
+        pruned,
+        IcebergArrowInputSourceReader.DEFAULT_BATCH_SIZE
     );
 
     final List<InputRow> rows = readAll(reader);
@@ -196,29 +212,34 @@ public void testLargeBatch() throws IOException
     writeRows(table, data);
 
     final IcebergArrowInputSourceReader reader = new IcebergArrowInputSourceReader(
-        table, null, null, true, INPUT_SCHEMA, IcebergArrowInputSourceReader.DEFAULT_BATCH_SIZE
+        table,
+        null,
+        null,
+        true,
+        INPUT_SCHEMA,
+        IcebergArrowInputSourceReader.DEFAULT_BATCH_SIZE
     );
 
     final List<InputRow> rows = readAll(reader);
     Assert.assertEquals(count, rows.size());
   }
 
   @Test
-  public void testSnapshotTime() throws IOException
+  public void testSnapshotTime() throws IOException, InterruptedException
   {
     final Table table = catalog.retrieveCatalog().createTable(tableId, SCHEMA);
     writeRows(table, row(1_000L, "snap1", 1.0));
     final long afterFirstSnapshot = System.currentTimeMillis();
 
     // Small sleep to ensure second snapshot has later timestamp
-    try { Thread.sleep(10); } catch (InterruptedException ignored) { }
+    Thread.sleep(10);
     writeRows(table, row(2_000L, "snap2", 2.0));
 
     // Read as-of the first snapshot — should only see 1 row.
     final IcebergArrowInputSourceReader reader = new IcebergArrowInputSourceReader(
         table,
         null,
-        new org.joda.time.DateTime(afterFirstSnapshot),
+        DateTimes.utc(afterFirstSnapshot),
         true,
         INPUT_SCHEMA,
         IcebergArrowInputSourceReader.DEFAULT_BATCH_SIZE
@@ -277,9 +298,14 @@ private static List<InputRow> readAll(final IcebergArrowInputSourceReader reader
   private static final class NoopInputStats implements org.apache.druid.data.input.InputStats
   {
     @Override
-    public void incrementProcessedBytes(final long v) {}
+    public void incrementProcessedBytes(final long v)
+    {
+    }
 
     @Override
-    public long getProcessedBytes() { return 0; }
+    public long getProcessedBytes()
+    {
+      return 0;
+    }
   }
 }