[DRAFT] Queue Semantics support in Kafka Ingestion#19311
Open
Shekharrajak wants to merge 18 commits intoapache:masterfrom
Open
[DRAFT] Queue Semantics support in Kafka Ingestion#19311Shekharrajak wants to merge 18 commits intoapache:masterfrom
Shekharrajak wants to merge 18 commits intoapache:masterfrom
Conversation
…r queue-semantics ingestion
…re group ingestion
…plicit acknowledgement
…Supplier, and ShareGroupIndexTask
…ord constructors, add mockito dep
…3.9.1 for full build compat
…xplicit ACK after publish
Shekharrajak
commented
Apr 15, 2026
| cd apache-druid-31.0.0 | ||
|
|
||
| # Replace the kafka extension with our build | ||
| rm extensions/druid-kafka-indexing-service/*.jar |
Contributor
Author
There was a problem hiding this comment.
We can build from the source and use the tar
Shekharrajak
commented
Apr 15, 2026
| agg -> agg.hasSumAtLeast(numRecords) | ||
| ); | ||
|
|
||
| Assertions.assertEquals( |
Contributor
Author
There was a problem hiding this comment.
Making sure we read all the records.
|
|
||
| for (ByteEntity entity : record.getData()) { | ||
| try { | ||
| final InputRow row = parseRow(entity, inputFormat, inputRowSchema, toolbox); |
Member
There was a problem hiding this comment.
[P1] Share-group ingestion drops rows when one Kafka record expands to multiple rows
This runner processes each Kafka message as though it produces exactly one InputRow. parseRow() only returns iterator.next(), so later rows from the same message are silently discarded, and zero-row messages can pass null into driver.add. Because the code still ACKs the Kafka record after publish, those skipped rows are lost permanently rather than being retried.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 #18439.
Description
Fixed the bug ...
Renamed the class ...
Added a forbidden-apis entry ...
Release note
Key changed/added classes in this PR
MyFooOurBarTheirBazThis PR has:
Demo
https://youtu.be/K_O1MH-AaE8