feat: Added query mode for skipping incremental segments during query#19545
Open
pirvtech wants to merge 3 commits into
Open
feat: Added query mode for skipping incremental segments during query#19545pirvtech wants to merge 3 commits into
pirvtech wants to merge 3 commits into
Conversation
FrankChen021
reviewed
Jun 3, 2026
Member
FrankChen021
left a comment
There was a problem hiding this comment.
| Severity | Findings |
|---|---|
| P0 | 0 |
| P1 | 0 |
| P2 | 1 |
| P3 | 0 |
| Total | 1 |
Reviewed 4 of 4 changed files.
This is an automated review by Codex GPT-5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Querying incremental segments that are being created during streaming ingestion is slower as rows are scanned sequentially. There exists an undocumented feature to skip these segments for query by passing a flag "skipIncrementalSegment" in the query context.
Query context has a documented flag for the query mode on real time segments called "realtimeSegmentsMode" and supports a few modes already. Adding a new mode to skip the incremental segments.
Key changed/added classes in this PR
processing/src/main/java/org/apache/druid/query/QueryContexts.java
server/src/main/java/org/apache/druid/client/CachingClusteredClient.java
server/src/main/java/org/apache/druid/segment/realtime/appenderator/SinkQuerySegmentWalker.java
This PR has: