Skip to content

minor: Add segment debug logging to CachingClusteredClient #19648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cecemei wants to merge 5 commits into
base: master
Choose a base branch
from
Open

minor: Add segment debug logging to CachingClusteredClient #19648

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7edd594
log
cecemei Jul 1, 2026
e15f3bc
always-log
cecemei Jul 1, 2026
c526b7a
Revert "always-log"
cecemei Jul 1, 2026
e600674
style
cecemei Jul 1, 2026
61352f5
debug
cecemei Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions server/src/main/java/org/apache/druid/client/CachingClusteredClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,20 @@ ClusterQueryResult<T> run(
}

final Set<SegmentServerSelector> segmentServers = computeSegmentsToQuery(timeline, specificSegments);
if (query.context().isDebug()) {
Comment thread
cecemei marked this conversation as resolved.
final String dataSource = ev.getBaseTableDataSource().getName();
log.infoSegmentIds(
segmentServers.stream().map(
s -> SegmentId.of(
dataSource,
s.getSegmentDescriptor().getInterval(),

@FrankChen021 FrankChen021 Jul 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Log real segment IDs, not query slices

The debug log rebuilds a SegmentId from SegmentDescriptor.getInterval(), but computeSegmentsToQuery fills that descriptor from TimelineObjectHolder.getInterval(). VersionedIntervalTimeline.lookup trims the first or last holder to the requested interval, so a query over one day inside a week-long segment logs a synthetic segment id that never existed. Use s.getServer().getSegment().getId() for the segment id, and log the query interval separately if needed.

s.getSegmentDescriptor().getVersion(),
s.getSegmentDescriptor().getPartitionNumber()
)
),
StringUtils.format("Query[%s] found segments from timeline lookup", query.getId())
);
}
final CloneQueryMode cloneQueryMode = query.context().getCloneQueryMode();
@Nullable
final byte[] queryCacheKey = cacheKeyManager.computeSegmentLevelQueryCacheKey();
Expand Down
Loading