refactor(versioning): drop unused helpers and aliases

Author: mochengqian

pkg/config/versioning/config.go

@@ -21,6 +21,7 @@ import (
 	"encoding/json"
 
 	"github.com/apache/dubbo-admin/pkg/common/bizerror"
+	"github.com/apache/dubbo-admin/pkg/config"
 )
 
 const (
@@ -32,6 +33,7 @@ const (
 )
 
 type Config struct {
+	config.BaseConfig
 	Enabled            bool  `json:"enabled" yaml:"enabled"`
 	MaxVersionsPerRule int64 `json:"maxVersionsPerRule" yaml:"maxVersionsPerRule"`
 	CoalesceWindowMs   int64 `json:"coalesceWindowMs" yaml:"coalesceWindowMs"`
@@ -71,14 +73,6 @@ func (c *Config) Sanitize() {
 	}
 }
 
-func (c *Config) PreProcess() error {
-	return nil
-}
-
-func (c *Config) PostProcess() error {
-	return nil
-}
-
 func (c *Config) Validate() error {
 	if c.MaxVersionsPerRule <= 0 {
 		return bizerror.New(bizerror.ConfigError, "versioning.maxVersionsPerRule must be greater than 0")

pkg/console/service/rule_version.go

@@ -46,7 +46,7 @@ func checkExpectedVersion(ctx consolectx.Context, kindName RuleKindName, opts Ru
 	return svc.CheckExpected(kindName.Kind, kindName.Mesh, kindName.Name, opts.ExpectedVersionID)
 }
 
-func putAdminHint(ctx consolectx.Context, res versionedResource, op versioning.Operation, opts RuleMutationOptions) error {
+func putAdminHint(ctx consolectx.Context, res coremodel.Resource, op versioning.Operation, opts RuleMutationOptions) error {
 	svc := ruleVersioning(ctx)
 	if svc == nil {
 		return nil
@@ -72,10 +72,6 @@ func getExistingRule(ctx consolectx.Context, kindName RuleKindName) (coremodel.R
 	return res, nil
 }
 
-type versionedResource interface {
-	coremodel.Resource
-}
-
 func ListRuleVersions(ctx consolectx.Context, kindName RuleKindName) (*versioning.ListResult, error) {
 	return ctx.RuleVersioning().List(kindName.Kind, kindName.Mesh, kindName.Name)
 }

pkg/core/manager/manager_helper.go

@@ -59,24 +59,6 @@ func GetByKeys[T model.Resource](rm ReadOnlyResourceManager, rk model.ResourceKi
 	return typedResources, nil
 }
 
-func List[T model.Resource](rm ReadOnlyResourceManager, rk model.ResourceKind) ([]T, error) {
-	resources, err := rm.List(rk)
-	if err != nil {
-		return nil, err
-	}
-
-	typedResources := make([]T, len(resources))
-	for i, resource := range resources {
-		typedResource, ok := resource.(T)
-		if !ok {
-			return nil, bizerror.NewAssertionError(rk, reflect.TypeOf(typedResource).Name())
-		}
-		typedResources[i] = typedResource
-	}
-
-	return typedResources, nil
-}
-
 // ListByIndexes is a helper function of ResourceManager.ListByIndexes
 func ListByIndexes[T model.Resource](rm ReadOnlyResourceManager, rk model.ResourceKind, indexes []index.IndexCondition) ([]T, error) {
 	resources, err := rm.ListByIndexes(rk, indexes)