Skip to content

Commit 8bac82a

Browse files
authored
Replace simpleclient_pushgateway dependency with dubbo-metrics-prometheus dependency to prepare bumping prometheus version (#1291)
1 parent de5daf5 commit 8bac82a

5 files changed

Lines changed: 8 additions & 8 deletions

File tree

4-governance/dubbo-samples-metrics-prometheus/dubbo-samples-metrics-prometheus-consumer/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@
6565
<artifactId>micrometer-registry-prometheus</artifactId>
6666
</dependency>
6767
<dependency>
68-
<groupId>io.prometheus</groupId>
69-
<artifactId>simpleclient_pushgateway</artifactId>
68+
<groupId>org.apache.dubbo</groupId>
69+
<artifactId>dubbo-metrics-prometheus</artifactId>
7070
</dependency>
7171
</dependencies>
7272

4-governance/dubbo-samples-metrics-prometheus/dubbo-samples-metrics-prometheus-consumer/src/test/java/org/apache/dubbo/samples/metrics/prometheus/consumer/ConsumerMetricsIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ public void test() throws Exception {
147147
}
148148
context.stop();
149149
for (String metricKey : notExistedList) {
150-
logger.error("metric key:{} don't exists", metricKey);
150+
logger.error("metric key:{} doesn't exist", metricKey);
151151
}
152152
Assert.assertTrue(notExistedList.isEmpty());
153153
}

4-governance/dubbo-samples-metrics-prometheus/dubbo-samples-metrics-prometheus-provider/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@
6767
<artifactId>micrometer-registry-prometheus</artifactId>
6868
</dependency>
6969
<dependency>
70-
<groupId>io.prometheus</groupId>
71-
<artifactId>simpleclient_pushgateway</artifactId>
70+
<groupId>org.apache.dubbo</groupId>
71+
<artifactId>dubbo-metrics-prometheus</artifactId>
7272
</dependency>
7373
</dependencies>
7474

4-governance/dubbo-samples-metrics-prometheus/dubbo-samples-metrics-prometheus-provider/src/test/java/org/apache/dubbo/samples/metrics/prometheus/provider/ProviderMetricsIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ public void test() throws Exception {
163163
}
164164
context.stop();
165165
for (String metricKey : notExistedList) {
166-
logger.error("metric key:{} don't exists", metricKey);
166+
logger.error("metric key:{} doesn't exist", metricKey);
167167
}
168168
Assert.assertTrue(notExistedList.isEmpty());
169169
}

4-governance/dubbo-samples-metrics-prometheus/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@
3737
<module>dubbo-samples-metrics-prometheus-consumer</module>
3838
</modules>
3939

40-
<name>Dubbo Samples Metrics Prometheus</name>
41-
<description>Dubbo Samples Metrics Prometheus</description>
40+
<name>Dubbo Samples Metrics Prometheus for Spring Boot 2</name>
41+
<description>Dubbo Samples Metrics Prometheus for Spring Boot 2</description>
4242

4343
<properties>
4444
<maven.compiler.source>1.8</maven.compiler.source>

0 commit comments

Comments
 (0)