Require comparable elements for CollectionUtils.sort#16257
Closed
mike-lmctl wants to merge 1 commit intoapache:3.3from
Closed
Require comparable elements for CollectionUtils.sort#16257mike-lmctl wants to merge 1 commit intoapache:3.3from
mike-lmctl wants to merge 1 commit intoapache:3.3from
Conversation
CollectionUtils.sort delegates to Collections.sort, but its generic signature did not expose the natural-ordering requirement. That let callers pass a list whose element type was not comparable and defer the failure to runtime. Add the same Comparable bound used by Collections.sort and remove the raw cast. Tested: ./mvnw -pl dubbo-common -Dtest=CollectionUtilsTest#testSort+testSortNull test Tested: ./mvnw -pl dubbo-cluster -am -DskipTests compile Signed-off-by: Mike Ma <mike.ma@lmctl.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16257 +/- ##
============================================
+ Coverage 60.78% 60.80% +0.02%
- Complexity 11763 11769 +6
============================================
Files 1953 1953
Lines 89186 89186
Branches 13454 13454
============================================
+ Hits 54209 54232 +23
+ Misses 29400 29384 -16
+ Partials 5577 5570 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Duplicated with #16236 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
GitHub_issue: #16235
CollectionUtils.sortdelegates toCollections.sort, but its genericsignature did not require comparable elements. This adds the same
Comparablebound and removes the raw cast, so invalid callers fail atcompile time instead of at runtime.
The existing sort tests still pass, and the affected cluster module compiles
with the stricter signature.
Tests:
Checklist