fix(line): respect disabled emphasis in hover. close #21634#21664
Open
rahul37wallst-sudo wants to merge 1 commit into
Open
fix(line): respect disabled emphasis in hover. close #21634#21664rahul37wallst-sudo wants to merge 1 commit into
rahul37wallst-sudo wants to merge 1 commit into
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Respect disabled emphasis for line-series tooltip hover symbols.
Fixed issues
Details
Before: What was the problem?
For dense canvas line series with
showSymbol: false,useDirtyRect: true,tooltip axis-pointer hover, and
emphasis: { disabled: true },LineView.highlight()could still create a temporary hover symbol.That temporary symbol was later removed during downplay. The add/remove
lifecycle could leave stale or corrupted line pixels when dirty-rect repainting
was enabled.
This reproduced with the issue's ECharts 6.1.0 canvas scenario:
showSymbol: falseprogressivevisualMaptrigger: 'axis'useDirtyRect: trueemphasis: { disabled: true }After: How does it behave after the fixing?
When line-series emphasis is disabled,
LineView.highlight()no longer createsor highlights a temporary hover symbol, and
downplay()avoids symbol/wholeseries downplay work for disabled emphasis.
The existing polyline state transition is kept so dirty-rect invalidation still
clears tooltip axis-pointer updates correctly.
Verified with a pixel-diff harness comparing a dirty-rect chart against a
full-repaint control:
showTipaction: 0 mismatcheshideTip: 0 mismatchesAlso passed:
Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Merging options
Other information
This fix was investigated together with ecomfe/zrender#1159. The ZRender
dirty-rect changes improved related behavior but did not fully resolve this
ECharts-side temp-symbol path. The final fix here is independent of ZRender
changes.