fix(toolbox): clear global cursor on restore. close #21644#21669
Open
rahul37wallst-sudo wants to merge 1 commit into
Open
fix(toolbox): clear global cursor on restore. close #21644#21669rahul37wallst-sudo wants to merge 1 commit into
rahul37wallst-sudo wants to merge 1 commit into
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Reset the active toolbox dataZoom selection cursor when toolbox restore is clicked.
Fixed issues
Details
Before: What was the problem?
After activating toolbox dataZoom selection and then clicking toolbox restore, the chart data range was restored, but the dataZoom selection cursor/brush state could remain active.
This left the chart in the zoom selection interaction mode after restore.
After: How does it behave after the fixing?
Toolbox restore now releases the global cursor before dispatching the restore action.
This disables the active dataZoom select brush state, restores the toolbox zoom icon to normal, and prevents the stale zoom selection cursor from remaining active after restore.
A unit test was added for the toolbox dataZoom restore path.
Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
test/ut/spec/component/toolbox/DataZoom.test.tsMerging options
Other information
Validation run:
npx jest --config test/ut/jest.config.cjs --coverage=false test/ut/spec/component/toolbox/DataZoom.test.ts --runInBandnpx eslint src/component/toolbox/feature/Restore.ts test/ut/spec/component/toolbox/DataZoom.test.tsgit diff --checknpm run checktype