This repository was archived by the owner on Apr 4, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
Archival patch (Checkstyles not handled) #45
Open
pragya-mittal
wants to merge
38
commits into
apache:master
Choose a base branch
from
pragya-mittal:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
3b7fd63
FALCON-1829 Add regression for submit and schedule process on native …
pragya-mittal 4c19ec0
Merge branch 'master' of https://github.com/apache/falcon
pragya-mittal f037385
Merge branch 'master' of https://github.com/apache/falcon
pragya-mittal 3c302e2
Merge branch 'master' of https://github.com/apache/falcon
pragya-mittal db094ea
FALCON-1832 Adding tags in SchedulableEntityInstance.compareTo()
pragya-mittal cd0664a
Revert "FALCON-1832 Adding tags in SchedulableEntityInstance.compareT…
pragya-mittal 26c462a
Merge branch 'master' of https://github.com/apache/falcon
pragya-mittal b674558
FALCON-1839 Test case for APIs for entities scheduled on native sched…
pragya-mittal bbf551a
Review commenst addressed
pragya-mittal a1a15af
FALCON-1841 Grouping test in falcon for running nightly regression
pragya-mittal 5ff0493
Merge branch 'master' of https://github.com/apache/falcon
pragya-mittal 97a155f
Review comments addressed
pragya-mittal b92d3f2
Review comments addressed
pragya-mittal 9a882df
Modifying totalMinutesToWait in NativeInstancEUtil to wait for defin…
pragya-mittal d244279
Modifying NativeInstanceUtil.waitTillInstancesAreCreated based on rev…
pragya-mittal cb335be
Modifying CHANGES.txt
pragya-mittal 8b95448
Adding doc for NativeInstanceUtil.waitTillInstancesAreCreated
pragya-mittal 9009d39
Adding assertion
pragya-mittal 4fd3cf8
Making waitTillInstanceReachState generic
pragya-mittal c800405
Addressed review comments
pragya-mittal a7baab5
Modified Changes.txt
pragya-mittal 4727e1d
Merge branch 'grouping'
pragya-mittal 9b65194
Merge branch 'native-api'
pragya-mittal d53fd46
Merge branch 'master' of https://github.com/apache/falcon
pragya-mittal fcfc291
Merge branch 'master' of https://github.com/apache/falcon
pragya-mittal 93a7253
Initial archival patch (Checkstyles, docs and test cases not handled)
pragya-mittal 204532f
Adding queue to archival workflow
pragya-mittal 753f7ca
Adding validation fro archivalPolicy
pragya-mittal ab8eb90
Adding policy to startup.properties
pragya-mittal 73c354c
Changing validate lifecycle in FeedEntityParser
pragya-mittal e332108
Adding twiki changes and fixing FeedHelperTest
pragya-mittal e107a94
Adding test cases for feed archival
pragya-mittal 38a70c3
Setting datasets in AgeBasedArchivalCoordinatorBuilder
pragya-mittal 0bbe6e4
Minor nit
pragya-mittal 724f8b5
Adding EntityOperations.ARCHIVE
pragya-mittal 16955ca
Fixing path in workflow builder
pragya-mittal 098548f
Minor checkstyle fix
pragya-mittal 3eb2109
Minor checkstyle fix
pragya-mittal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could potentially throw NPE since tags could be null. Instead, you can use null-safe comparison provided by ObjectUtils class -
result = ObjectUtils.compare(this.tags, o.tags);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @deepakbarr @pragya-mittal can you please make the relevant change and update the pull request?