Skip to content
This repository was archived by the owner on Apr 4, 2021. It is now read-only.
Open
Changes from 5 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
3b7fd63
FALCON-1829 Add regression for submit and schedule process on native …
pragya-mittal Feb 11, 2016
4c19ec0
Merge branch 'master' of https://github.com/apache/falcon
pragya-mittal Feb 11, 2016
f037385
Merge branch 'master' of https://github.com/apache/falcon
pragya-mittal Feb 12, 2016
3c302e2
Merge branch 'master' of https://github.com/apache/falcon
pragya-mittal Feb 17, 2016
db094ea
FALCON-1832 Adding tags in SchedulableEntityInstance.compareTo()
pragya-mittal Feb 17, 2016
cd0664a
Revert "FALCON-1832 Adding tags in SchedulableEntityInstance.compareT…
pragya-mittal Feb 24, 2016
26c462a
Merge branch 'master' of https://github.com/apache/falcon
pragya-mittal Feb 24, 2016
b674558
FALCON-1839 Test case for APIs for entities scheduled on native sched…
pragya-mittal Feb 24, 2016
bbf551a
Review commenst addressed
pragya-mittal Feb 25, 2016
a1a15af
FALCON-1841 Grouping test in falcon for running nightly regression
pragya-mittal Feb 29, 2016
5ff0493
Merge branch 'master' of https://github.com/apache/falcon
pragya-mittal Feb 29, 2016
97a155f
Review comments addressed
pragya-mittal Feb 29, 2016
b92d3f2
Review comments addressed
pragya-mittal Feb 29, 2016
9a882df
Modifying totalMinutesToWait in NativeInstancEUtil to wait for defin…
pragya-mittal Feb 29, 2016
d244279
Modifying NativeInstanceUtil.waitTillInstancesAreCreated based on rev…
pragya-mittal Mar 1, 2016
cb335be
Modifying CHANGES.txt
pragya-mittal Mar 1, 2016
8b95448
Adding doc for NativeInstanceUtil.waitTillInstancesAreCreated
pragya-mittal Mar 1, 2016
9009d39
Adding assertion
pragya-mittal Mar 1, 2016
4fd3cf8
Making waitTillInstanceReachState generic
pragya-mittal Mar 3, 2016
c800405
Addressed review comments
pragya-mittal Mar 4, 2016
a7baab5
Modified Changes.txt
pragya-mittal Mar 7, 2016
4727e1d
Merge branch 'grouping'
pragya-mittal Mar 7, 2016
9b65194
Merge branch 'native-api'
pragya-mittal Mar 7, 2016
d53fd46
Merge branch 'master' of https://github.com/apache/falcon
pragya-mittal Mar 7, 2016
fcfc291
Merge branch 'master' of https://github.com/apache/falcon
pragya-mittal Oct 11, 2017
93a7253
Initial archival patch (Checkstyles, docs and test cases not handled)
pragya-mittal Nov 20, 2017
204532f
Adding queue to archival workflow
pragya-mittal Nov 21, 2017
753f7ca
Adding validation fro archivalPolicy
pragya-mittal Nov 21, 2017
ab8eb90
Adding policy to startup.properties
pragya-mittal Nov 21, 2017
73c354c
Changing validate lifecycle in FeedEntityParser
pragya-mittal Nov 21, 2017
e332108
Adding twiki changes and fixing FeedHelperTest
pragya-mittal Nov 24, 2017
e107a94
Adding test cases for feed archival
pragya-mittal Nov 27, 2017
38a70c3
Setting datasets in AgeBasedArchivalCoordinatorBuilder
pragya-mittal Nov 30, 2017
0bbe6e4
Minor nit
pragya-mittal Nov 30, 2017
724f8b5
Adding EntityOperations.ARCHIVE
pragya-mittal Dec 4, 2017
16955ca
Fixing path in workflow builder
pragya-mittal Dec 4, 2017
098548f
Minor checkstyle fix
pragya-mittal Dec 4, 2017
3eb2109
Minor checkstyle fix
pragya-mittal Dec 4, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,11 @@ public int compareTo(SchedulableEntityInstance o) {
return result;
}

result = this.tags.compareTo(o.tags);
if (result != 0) {
return result;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could potentially throw NPE since tags could be null. Instead, you can use null-safe comparison provided by ObjectUtils class -
result = ObjectUtils.compare(this.tags, o.tags);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @deepakbarr @pragya-mittal can you please make the relevant change and update the pull request?

return this.instanceTime.compareTo(o.instanceTime);
}
}