Skip to content

Commit 894030e

Browse files
author
Likitha
committed
i
FINERACT-2571: Migrate charge creation helper to feign client Migrate charge creation helper to feign client FINERACT-2571: Migrate charge creation helper to feign client
1 parent 89eb49c commit 894030e

File tree

1 file changed

+13
-5
lines changed
  • integration-tests/src/test/java/org/apache/fineract/integrationtests/common/charges

1 file changed

+13
-5
lines changed

integration-tests/src/test/java/org/apache/fineract/integrationtests/common/charges/ChargesHelper.java

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -598,18 +598,26 @@ public static HashMap<String, Object> populateDefaultsShareRedeemFlatCharge() {
598598
// org.apache.fineract.client.models.PostLoansLoanIdRequest)
599599
@Deprecated(forRemoval = true)
600600
public static Integer createCharges(final RequestSpecification requestSpec, final ResponseSpecification responseSpec,
601-
final String request) {
602-
return Utils.performServerPost(requestSpec, responseSpec, CREATE_CHARGES_URL, request, "resourceId");
601+
final String request) {
602+
ChargeRequest chargeRequest = GSON.fromJson(request, ChargeRequest.class);
603+
PostChargesResponse response = Calls.ok(FineractClientHelper.getFineractClient().charges.createCharge(chargeRequest));
604+
return response.getResourceId().intValue();
603605
}
604606

605607
// TODO: Rewrite to use fineract-client instead!
606608
// Example: org.apache.fineract.integrationtests.common.loans.LoanTransactionHelper.disburseLoan(java.lang.Long,
607609
// org.apache.fineract.client.models.PostLoansLoanIdRequest)
608610
@Deprecated(forRemoval = true)
609611
public static PostChargesResponse createLoanCharge(final RequestSpecification requestSpec, final ResponseSpecification responseSpec,
610-
final String payload) {
611-
final String response = Utils.performServerPost(requestSpec, responseSpec, CREATE_CHARGES_URL, payload, null);
612-
return GSON.fromJson(response, PostChargesResponse.class);
612+
final String payload) {
613+
614+
ChargeRequest chargeRequest = GSON.fromJson(payload, ChargeRequest.class);
615+
616+
return Calls.ok(
617+
FineractClientHelper.getFineractClient()
618+
.charges()
619+
.createCharge(chargeRequest)
620+
);
613621
}
614622

615623
// TODO: Rewrite to use fineract-client instead!

0 commit comments

Comments
 (0)