Skip to content

FINERACT-2455: Simplify reset logic#6109

Open
adamsaghy wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2455/simplify-calculations
Open

FINERACT-2455: Simplify reset logic#6109
adamsaghy wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2455/simplify-calculations

Conversation

@adamsaghy

Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@adamsaghy adamsaghy force-pushed the FINERACT-2455/simplify-calculations branch 2 times, most recently from bfb9f18 to 458da07 Compare July 9, 2026 08:41
@adamsaghy adamsaghy force-pushed the FINERACT-2455/simplify-calculations branch 2 times, most recently from b5b4443 to 71c7b2b Compare July 9, 2026 12:38

@Cocoa-Puffs Cocoa-Puffs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adamsaghy adamsaghy requested a review from budaidev July 9, 2026 13:47
@mariiaKraievska

Copy link
Copy Markdown
Contributor

Everything else LGTM!

@adamsaghy adamsaghy force-pushed the FINERACT-2455/simplify-calculations branch from 71c7b2b to 614d338 Compare July 9, 2026 16:07
@adamsaghy adamsaghy requested a review from budaidev July 9, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants