Skip to content

Commit 89c4897

Browse files
committed
fixed checkstyle
1 parent 7e15ed7 commit 89c4897

43 files changed

Lines changed: 213 additions & 85 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/pom.xml

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -164,17 +164,23 @@ limitations under the License.
164164
</exclusions>
165165
</dependency>
166166

167+
<dependency>
168+
<groupId>io.debezium</groupId>
169+
<artifactId>debezium-connector-mysql</artifactId>
170+
<version>1.9.8.Final</version>
171+
<scope>compile</scope>
172+
</dependency>
167173
<dependency>
168174
<groupId>org.apache.flink</groupId>
169175
<artifactId>flink-cdc-base</artifactId>
170-
<version>3.4-SNAPSHOT</version>
176+
<version>${project.version}</version>
171177
<scope>compile</scope>
172178
</dependency>
173179
<dependency>
174-
<groupId>io.debezium</groupId>
175-
<artifactId>debezium-connector-mysql</artifactId>
176-
<version>1.9.8.Final</version>
177-
<scope>compile</scope>
180+
<groupId>org.apache.flink</groupId>
181+
<artifactId>flink-connector-test-util</artifactId>
182+
<version>${project.version}</version>
183+
<scope>test</scope>
178184
</dependency>
179185

180186
</dependencies>

flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/main/java/org/apache/flink/cdc/connectors/tidb/metrics/TiDBSourceMetrics.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,15 @@
2424
import static org.apache.flink.runtime.metrics.MetricNames.CURRENT_FETCH_EVENT_TIME_LAG;
2525
import static org.apache.flink.runtime.metrics.MetricNames.SOURCE_IDLE_TIME;
2626

27-
/** A collection class for handling metrics in {@link }. */
27+
/** A collection class for handling metrics in {@link TiKVRichParallelSourceFunction}. */
2828
public class TiDBSourceMetrics {
2929

3030
private final MetricGroup metricGroup;
3131

3232
/**
33-
* The last record processing time, which is updated after {@link } fetches a batch of data.
34-
* It's mainly used to report metrics sourceIdleTime for sourceIdleTime =
35-
* System.currentTimeMillis() - processTime.
33+
* The last record processing time, which is updated after {@link
34+
* TiKVRichParallelSourceFunction} fetches a batch of data. It's mainly used to report metrics
35+
* sourceIdleTime for sourceIdleTime = System.currentTimeMillis() - processTime.
3636
*/
3737
private long processTime = 0L;
3838

flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/main/java/org/apache/flink/cdc/connectors/tidb/source/TiDBDialect.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
import java.util.List;
5555
import java.util.Map;
5656

57+
/** TiDB data source dialect. */
5758
public class TiDBDialect implements JdbcDataSourceDialect {
5859
private static final Logger LOG = LoggerFactory.getLogger(TiDBDialect.class);
5960

flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/main/java/org/apache/flink/cdc/connectors/tidb/source/TiDBSourceBuilder.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333

3434
import static org.apache.flink.cdc.common.utils.Preconditions.checkNotNull;
3535

36+
/** Builder for {@link JdbcIncrementalSource}. */
3637
public class TiDBSourceBuilder<T> {
3738
private final TiDBSourceConfigFactory configFactory = new TiDBSourceConfigFactory();
3839
private EventOffsetFactory offsetFactory;
@@ -187,6 +188,7 @@ public TiDBIncrementalSource<T> build() {
187188
configFactory, checkNotNull(deserializer), offsetFactory, dialect);
188189
}
189190

191+
/** TiDB incremental source. */
190192
public static class TiDBIncrementalSource<T> extends JdbcIncrementalSource<T> {
191193
public TiDBIncrementalSource(
192194
JdbcSourceConfigFactory configFactory,

flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/main/java/org/apache/flink/cdc/connectors/tidb/source/config/TiDBConnectorConfig.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
import java.util.Collections;
4040
import java.util.List;
4141

42+
/** TiDB connector configuration. */
4243
public class TiDBConnectorConfig extends RelationalDatabaseConnectorConfig {
4344
private static final Logger LOGGER = LoggerFactory.getLogger(TiDBConnectorConfig.class);
4445

@@ -85,7 +86,8 @@ public class TiDBConnectorConfig extends RelationalDatabaseConnectorConfig {
8586
+ "false - delegates the implicit conversion to the database"
8687
+ "true - (the default) Debezium makes the conversion");
8788

88-
public static enum BigIntUnsignedHandlingMode implements EnumeratedValue {
89+
/** The set of predefined options for the handling mode configuration property. */
90+
public enum BigIntUnsignedHandlingMode implements EnumeratedValue {
8991
/**
9092
* Represent {@code BIGINT UNSIGNED} values as precise {@link BigDecimal} values, which are
9193
* represented in change events in a binary form. This is precise but difficult to use.
@@ -203,7 +205,8 @@ public boolean isReadOnlyConnection() {
203205
return readOnlyConnection;
204206
}
205207

206-
public static enum SecureConnectionMode implements EnumeratedValue {
208+
/** Whether to use SSL/TLS to connect to the database. */
209+
public enum SecureConnectionMode implements EnumeratedValue {
207210
/** Establish an unencrypted connection. */
208211
DISABLED("disabled"),
209212

flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/main/java/org/apache/flink/cdc/connectors/tidb/source/config/TiDBSourceConfig.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import java.util.Map;
3030
import java.util.Properties;
3131

32+
/** The configuration for TiDB source. */
3233
public class TiDBSourceConfig extends JdbcSourceConfig {
3334
private static final long serialVersionUID = 1L;
3435
private final String compatibleMode;

flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/main/java/org/apache/flink/cdc/connectors/tidb/source/config/TiDBSourceConfigFactory.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
* See the License for the specific language governing permissions and
1515
* limitations under the License.
1616
*/
17+
1718
package org.apache.flink.cdc.connectors.tidb.source.config;
1819

1920
import org.apache.flink.cdc.connectors.base.config.JdbcSourceConfigFactory;

flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/main/java/org/apache/flink/cdc/connectors/tidb/source/config/TiDBSourceOptions.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
* See the License for the specific language governing permissions and
1515
* limitations under the License.
1616
*/
17+
1718
package org.apache.flink.cdc.connectors.tidb.source.config;
1819

1920
import org.apache.flink.cdc.connectors.base.options.JdbcSourceOptions;
@@ -28,9 +29,10 @@
2829
import java.util.Map;
2930
import java.util.Optional;
3031

32+
/** Options for {@link org.apache.flink.cdc.connectors.tidb.table.TiDBTableSource}. */
3133
public class TiDBSourceOptions extends JdbcSourceOptions {
3234

33-
public static final ConfigOption<Integer> TiDB_PORT =
35+
public static final ConfigOption<Integer> TIDB_PORT =
3436
ConfigOptions.key("port")
3537
.intType()
3638
.defaultValue(4000)

flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/main/java/org/apache/flink/cdc/connectors/tidb/source/connection/TiDBConnection.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
import java.util.function.Supplier;
5555
import java.util.regex.Pattern;
5656

57+
/** TiDB JDBC connection. */
5758
public class TiDBConnection extends JdbcConnection {
5859
private static final Logger LOG = LoggerFactory.getLogger(TiDBConnection.class);
5960

flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/main/java/org/apache/flink/cdc/connectors/tidb/source/connection/TiDBConnectionPoolFactory.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import org.apache.flink.cdc.connectors.base.config.JdbcSourceConfig;
2121
import org.apache.flink.cdc.connectors.base.relational.connection.JdbcConnectionPoolFactory;
2222

23+
/** The factory to create {@link TiDBConnectionPool}. */
2324
public class TiDBConnectionPoolFactory extends JdbcConnectionPoolFactory {
2425
private static final String MYSQL_URL_PATTERN =
2526
"jdbc:mysql://%s:%s/?useUnicode=true&useSSL=false&useInformationSchema=true&nullCatalogMeansCurrent=false&zeroDateTimeBehavior=convertToNull&characterEncoding=UTF-8&characterSetResults=UTF-8";

0 commit comments

Comments
 (0)