[minor][pipeline-connector/sqlserver] Fix SQL Server schema restore without per-record JDBC#4446
Open
leonardBang wants to merge 3 commits into
Open
[minor][pipeline-connector/sqlserver] Fix SQL Server schema restore without per-record JDBC#4446leonardBang wants to merge 3 commits into
leonardBang wants to merge 3 commits into
Conversation
leonardBang
force-pushed
the
sqlserver_optimize
branch
from
62a6f7a to
2a816b6
Compare
…ithout per-record JDBC Restore CreateTableEvent state from source splits during reader initialization so savepoint recovery does not fall back to per-record JDBC lookups. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
leonardBang
force-pushed
the
sqlserver_optimize
branch
from
2a816b6 to
362c754
Compare
Contributor
Author
|
@Daishuyuan Would you like to review this PR when you have time? |
leonardBang
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures SQL Server pipeline schema state (CreateTableEvent cache) is restored from split state during reader initialization, preventing savepoint restores from degrading into JDBC-based schema lookups during record emission.
Changes:
- Invoke
IncrementalSourceRecordEmitter.applySplit(...)duringIncrementalSourceReader.initializedState(...)to let emitters hydrate per-split state early. - Add a focused unit test verifying
initializedState(...)applies the split to the record emitter. - Add an end-to-end SQL Server pipeline IT case covering schema evolution continuity across savepoint/restore.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.../IncrementalSourceReaderTest.java |
New unit test validating split application to the record emitter during initialization. |
.../IncrementalSourceReader.java |
Applies the split to IncrementalSourceRecordEmitter during split-state initialization. |
.../SqlServerPipelineSavepointRestoreITCase.java |
New SQL Server savepoint/restore IT verifying schema evolution continues after restore. |
.../SqlServerPipelineRecordEmitter.java |
Restores CreateTableEvent cache from split schemas and changes cache-miss behavior while emitting CreateTableEvent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@ruanhang1993 Would you like to help review this PR when you have time ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore CreateTableEvent state from source splits during reader initialization so savepoint recovery does not fall back to per-record JDBC lookups.