[FLINK-33557] Externalize Cassandra Python connector code#26
[FLINK-33557] Externalize Cassandra Python connector code#26ferenc-csaky wants to merge 1 commit intoapache:mainfrom
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
|
@pvary @gaborgsomogyi JAR included, CI run passed. |
|
|
||
| os.makedirs(LIB_PATH) | ||
| connector_jar = \ | ||
| glob.glob(CURRENT_DIR + '/target/test-dependencies/flink-connector-cassandra*.jar')[0] |
There was a problem hiding this comment.
QQ: Is this an uber jar for the connector?
There was a problem hiding this comment.
Yes, it includes the necessary cassandra related deps:
pvary
left a comment
There was a problem hiding this comment.
The packaging part looks good.
I have limited experience with the Cassandra connector, so I would like to have someone with Cassandra experience to review it too.
|
@echauchot Sorry to ping you out of the blue, I saw that you were an active contributor to the Cassandra connector. If you have some time, would you mind reviewing this PR? Thanks in advance! |
Hi @ferenc-csaky it would be with pleasure but I know nothing about python so I might not be the good person to review this PR |
fdab870 to
05fc150
Compare
Purpose of the change
Inspired by apache/flink-connector-kafka#69, and apache/flink-connector-aws#121. Moves
cassandra.pyandtest_cassandra.pyfrom the core https://github.com/apache/flink repo to this one.When running
mvn clean install, downloads the testing infra scripts from the main Flink repo:flink-python/dev/build-wheels.shflink-python/dev/install_command.shflink-python/dev/lint-python.shVerifying this change
The python tests can be run by the following commands: