[FLINK-37244] Added scylladb tests, documentation and README#40
Open
andrii-kysylevskyi wants to merge 1 commit intoapache:mainfrom
Open
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
Author
|
@Poorvankbhatia, I noticed you have reviewed a couple of PR's in this repository. Is there any chance you could take a look at this one when you have some time? Thank you! |
Contributor
Ack. I will review it. |
Author
|
Hi @Poorvankbhatia - just following up on this in case it got lost. Thank you in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive ScyllaDB support to the Flink Cassandra Connector, validating ScyllaDB as a drop-in replacement for Apache Cassandra. All connector features (sources, sinks, batch formats, exactly-once semantics) have been tested against ScyllaDB 2025.1.4 (latest open source version).
Motivation
ScyllaDB is a high-performance, drop-in replacement for Apache Cassandra that maintains full CQL protocol compatibility.
Implementation Approach
Following @echauchot's guidance to "add ITests on ScyllaDB using testContainers" without modifying production code, this PR introduces:
Test Infrastructure (4 new files)
Implementation Strategy
To avoid modifying the existing Cassandra test infrastructure, the new ScyllaDB tests mirror the structure of their Cassandra counterparts. All ScyllaDB test files are standalone copies with ScyllaDB-specific configuration:
CassandraTestEnvironmentwith ScyllaDB-specific container configuration (image:scylladb/scylla:2025.1.4, flags:--reactor-backend=epoll --smp 1, increased timeouts)CassandraTestContextto provide type-compatible test context factory for source testsCassandraSourceITCasewith all 11 test methods running against ScyllaDBCassandraConnectorITCasewith all 20+ sink and batch format tests running against ScyllaDBOriginal PR that got stale, can be found here
As suggested, inviting @dannycranmer or @zentol for a review. Thanks a lot in advance!