[FLINK-20979][elasticsearch] Fix docs: use '-1' to disable bulk-flush options#140
Open
jlalwani-amazon wants to merge 1 commit into
Open
[FLINK-20979][elasticsearch] Fix docs: use '-1' to disable bulk-flush options#140jlalwani-amazon wants to merge 1 commit into
jlalwani-amazon wants to merge 1 commit into
Conversation
… options The documentation incorrectly states that '0' disables sink.bulk-flush.max-actions, sink.bulk-flush.max-size, and sink.bulk-flush.interval. The code validates maxActions == -1 || maxActions >= 1, so '0' is actually invalid and '-1' is the correct disable value. Updated both English and Chinese docs.
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix incorrect documentation for
sink.bulk-flush.max-actions,sink.bulk-flush.max-size, andsink.bulk-flush.interval. The docs state that'0'disables these options, but the code validatesmaxActions == -1 || maxActions >= 1— so'0'is invalid and'-1'is the correct disable value.JIRA: FLINK-20979
Brief change log
'0'with'-1'in the disable description for bulk-flush options (English and Chinese docs)Does this pull request potentially affect one of the following parts?