Skip to content

[FLINK-20979][elasticsearch] Fix docs: use '-1' to disable bulk-flush options #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlalwani-amazon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FLINK-20979][elasticsearch] Fix docs: use '-1' to disable bulk-flush options #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/content.zh/docs/connectors/table/elasticsearch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ CREATE TABLE myUserTable (
<td style="word-wrap: break-word;">1000</td>
<td>Integer</td>
<td>每个批量请求的最大缓冲操作数。
可以设置为<code>'0'</code>来禁用它（<code>elasticsearch-8</code>中必须大于0）。
可以设置为<code>'-1'</code>来禁用它（<code>elasticsearch-8</code>中必须大于0）。
</td>
</tr>
<tr>
Expand All @@ -168,7 +168,7 @@ CREATE TABLE myUserTable (
<td style="word-wrap: break-word;">2mb</td>
<td>MemorySize</td>
<td>每个批量请求的缓冲操作在内存中的最大值。单位必须为 MB。
可以设置为<code>'0'</code>来禁用它（<code>elasticsearch-8</code>中必须大于0）。
可以设置为<code>'-1'</code>来禁用它（<code>elasticsearch-8</code>中必须大于0）。
</td>
</tr>
<tr>
Expand All @@ -177,7 +177,7 @@ CREATE TABLE myUserTable (
<td style="word-wrap: break-word;">1s</td>
<td>Duration</td>
<td>flush 缓冲操作的间隔。
可以设置为<code>'0'</code>来禁用它（<code>elasticsearch-8</code>中必须大于0）。注意，<code>'sink.bulk-flush.max-size'</code>和<code>'sink.bulk-flush.max-actions'</code>都设置为<code>'0'</code>的这种 flush 间隔设置允许对缓冲操作进行完全异步处理（<code>elasticsearch-8</code>不支持如此配置，因其底层的异步 sink 要求所有 flush 参数必须为正数）。
可以设置为<code>'-1'</code>来禁用它（<code>elasticsearch-8</code>中必须大于0）。注意，<code>'sink.bulk-flush.max-size'</code>和<code>'sink.bulk-flush.max-actions'</code>都设置为<code>'0'</code>的这种 flush 间隔设置允许对缓冲操作进行完全异步处理（<code>elasticsearch-8</code>不支持如此配置，因其底层的异步 sink 要求所有 flush 参数必须为正数）。
</td>
</tr>
<tr>
Expand Down
6 changes: 3 additions & 3 deletions docs/content/docs/connectors/table/elasticsearch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ Connector Options
<td style="word-wrap: break-word;">1000</td>
<td>Integer</td>
<td>Maximum number of buffered actions per bulk request.
Can be set to <code>'0'</code> to disable it (must be greater than 0 in <code>elasticsearch 8</code>).
Can be set to <code>'-1'</code> to disable it (must be greater than 0 in <code>elasticsearch 8</code>).
</td>
</tr>
<tr>
Expand All @@ -183,7 +183,7 @@ Connector Options
<td style="word-wrap: break-word;">2mb</td>
<td>MemorySize</td>
<td>Maximum size in memory of buffered actions per bulk request. Must be in MB granularity.
Can be set to <code>'0'</code> to disable it (must be greater than 0 in <code>elasticsearch 8</code>).
Can be set to <code>'-1'</code> to disable it (must be greater than 0 in <code>elasticsearch 8</code>).
</td>
</tr>
<tr>
Expand All @@ -193,7 +193,7 @@ Connector Options
<td style="word-wrap: break-word;">1s</td>
<td>Duration</td>
<td>The interval to flush buffered actions.
Can be set to <code>'0'</code> to disable it (must be greater than 0 in <code>elasticsearch 8</code>). Note, both <code>'sink.bulk-flush.max-size'</code> and <code>'sink.bulk-flush.max-actions'</code>
Can be set to <code>'-1'</code> to disable it (must be greater than 0 in <code>elasticsearch 8</code>). Note, both <code>'sink.bulk-flush.max-size'</code> and <code>'sink.bulk-flush.max-actions'</code>
can be set to <code>'0'</code> with the flush interval set allowing for complete async processing of buffered actions (not supported in <code>elasticsearch 8</code>, as its underlying async sink requires all flush parameters to be positive).
</td>
</tr>
Expand Down
Loading