Skip to content

Fix redundant implementation of interfaces and clean deprecated fabric8 methods#1011

Merged
gyfora merged 4 commits into
apache:mainfrom
kornys:code-cleanup-fixes
Aug 12, 2025
Merged

Fix redundant implementation of interfaces and clean deprecated fabric8 methods#1011
gyfora merged 4 commits into
apache:mainfrom
kornys:code-cleanup-fixes

Conversation

@kornys
Copy link
Copy Markdown
Contributor

@kornys kornys commented Aug 11, 2025

What is the purpose of the change

  • Code clean remove redundant implementation of Namespaced interface
  • Add .vscode to .gitignore
  • Fix letfover usage of deprecated createOrUpdate method from fabric8 in examples

Brief change log

(for example:)

  • Remove redundant implementation of Namespaced interface in API module
  • Clean deprecated usage of fabric8 methods in examples
  • .vscode folder is ignored by git

Verifying this change

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changes to the CustomResourceDescriptors: (no)
  • Core observer or reconciler logic that is regularly executed: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

kornys added 3 commits August 11, 2025 19:36
Signed-off-by: David Kornel <kornys@outlook.com>
Signed-off-by: David Kornel <kornys@outlook.com>
Signed-off-by: David Kornel <kornys@outlook.com>
@kornys
Copy link
Copy Markdown
Contributor Author

kornys commented Aug 11, 2025

@gyfora commits merged into one PR

Signed-off-by: David Kornel <kornys@outlook.com>
@kornys kornys requested a review from csviri August 12, 2025 06:52
Copy link
Copy Markdown
Contributor

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @kornys

@gyfora gyfora merged commit 2e58279 into apache:main Aug 12, 2025
121 checks passed
@kornys kornys deleted the code-cleanup-fixes branch August 12, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants