[FLINK-37193] Feature flag if operator should manage ingress#1018
Merged
Conversation
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
gyfora
reviewed
Aug 24, 2025
| EventRecorder eventRecorder) { | ||
| if (!ctx.getOperatorConfig().isManageIngress()) { | ||
| if (spec.getIngress() != null) { | ||
| log.warn(INGRESS_MANAGEMENT_OFF_BUT_SPEC_SET); |
Contributor
There was a problem hiding this comment.
No need to both log and trigger the event as events are already logged. Logging can be removed
gyfora
approved these changes
Aug 24, 2025
Contributor
gyfora
left a comment
gyfora
left a comment
There was a problem hiding this comment.
aside from the minor comment related to redundant logging, looks good
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This change adds a feature flag to set if the controller should manage the ingress. If set to false controller won't register the related InformerEventSource, and won't create ingress even if set in the spec.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors: noDocumentation