[FLINK-38293] Update Checkstyle version and related rules in Kubernetes Operator#1023
Conversation
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
changed the title
| <artifactId>checkstyle</artifactId> | ||
| <!-- Note: match version with docs/flinkDev/ide_setup.md --> | ||
| <version>8.14</version> | ||
| <version>10.17.0</version> |
There was a problem hiding this comment.
BTW, what about the above comment:
I don't see such file anymore or mentioning of com.puppycrawl.tools in the docs, it seems to be obsolete and probably should be deleted
There was a problem hiding this comment.
Is this dependency required? Why such an old version? Latest version is 11.0.1: https://mvnrepository.com/artifact/com.puppycrawl.tools/checkstyle
There was a problem hiding this comment.
Good point, I did not found anything about this in checkstyle docs either so removed it for now.
There was a problem hiding this comment.
Did you actually remove it? I still see it.
There was a problem hiding this comment.
pushed it now, sorry
kaygorodov
left a comment
kaygorodov
left a comment
There was a problem hiding this comment.
LGTM (not that it counts though). I think you need another look from @mxm
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
3 participants
What is the purpose of the change
Update checkstyle so it supports newer Java language features like text blocks, etc.
Brief change log
Updated checkstyle maven plugin and related rules.
Verifying this change
Run the build, it passes. Try to use a text block in a unit test for exmaple, now passes the build, unlike before.
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors: noDocumentation