[FLINK-38448] Rework doc build and doc deployment#1035
Merged
Conversation
…ync-deploy` action in `docs.yaml`
ferenc-csaky
force-pushed
the
FLINK-38448
branch
from
a532617 to
4b7038f
Compare
gyfora
reviewed
Sep 28, 2025
gyfora
left a comment
gyfora
left a comment
Contributor
There was a problem hiding this comment.
Can you please add a minimal context on why this change is required and where the new action.yml is coming from?
Contributor
Author
|
Context added to the Jira ticket. And the action.yml comes from me and ChatGPT :) |
Contributor
|
How about we simply copy the appropriate action from the burnett01/rsync-deployments codebase: https://github.com/Burnett01/rsync-deployments/tree/7.1.0 We could copy the logic as is, and add the MIT license in: |
Contributor
Author
That action runs in a Docker img. So we need to copy over pretty much the whole codebase (action.yml, Dockerfile, entrypoint.sh). It has the benefit of a fixed rsync version, I'm 99% sure it won't matter at all. I'm okay to do that though, just let me know if that would be preferred. |
Contributor
Author
|
Or as an alternative we could copy |
Contributor
|
I was just looking at the current code and comparing with the entry point.sh/action.yml. It already looks very very similar . |
gyfora
approved these changes
Sep 29, 2025
ferenc-csaky
force-pushed
the
FLINK-38448
branch
from
fcb4d44 to
8171f59
Compare
ferenc-csaky
force-pushed
the
FLINK-38448
branch
from
8171f59 to
d5bf4e6
Compare
ferenc-csaky
changed the title
burnett01/rsync-deployments with a custom rsync-deploy action in docs.yaml
ferenc-csaky
added a commit
that referenced
this pull request
Sep 29, 2025
ferenc-csaky
added a commit
that referenced
this pull request
Sep 29, 2025
GreatEugenius
added a commit
to GreatEugenius/flink-agents
that referenced
this pull request
May 25, 2026
The third-party burnett01/rsync-deployments action is not in the ASF allowed-actions list, causing the nightly docs workflow to fail. Replace it with a local composite action under .github/actions/rsync-deployments (ported from apache/flink-kubernetes-operator#1035), since locally-defined actions are not subject to the third-party allow-list.
GreatEugenius
added a commit
to GreatEugenius/flink-agents
that referenced
this pull request
May 25, 2026
Add a local composite action under .github/actions/rsync-deployments that wraps rsync-over-SSH for documentation deployment. Ported from apache/flink-kubernetes-operator#1035 with MIT attribution preserved. This action is intended to replace the third-party burnett01/rsync-deployments action, which is not in the ASF allowed-actions list. Locally-defined actions are not subject to that allow-list, so they can be used safely in ASF repositories. This commit is purely additive (no existing files modified) and can be cherry-picked cleanly to release branches so the nightly docs matrix job can resolve the local action when checking out those branches.
GreatEugenius
added a commit
to GreatEugenius/flink-agents
that referenced
this pull request
May 25, 2026
Add a local composite action under .github/actions/rsync-deployments that wraps rsync-over-SSH for documentation deployment. Ported from apache/flink-kubernetes-operator#1035 with MIT attribution preserved. This action is intended to replace the third-party burnett01/rsync-deployments action, which is not in the ASF allowed-actions list. Locally-defined actions are not subject to that allow-list, so they can be used safely in ASF repositories. This commit is purely additive (no existing files modified) and can be cherry-picked cleanly to release branches so the nightly docs matrix job can resolve the local action when checking out those branches.
3 tasks
xintongsong
pushed a commit
to apache/flink-agents
that referenced
this pull request
May 25, 2026
Add a local composite action under .github/actions/rsync-deployments that wraps rsync-over-SSH for documentation deployment. Ported from apache/flink-kubernetes-operator#1035 with MIT attribution preserved. This action is intended to replace the third-party burnett01/rsync-deployments action, which is not in the ASF allowed-actions list. Locally-defined actions are not subject to that allow-list, so they can be used safely in ASF repositories. This commit is purely additive (no existing files modified) and can be cherry-picked cleanly to release branches so the nightly docs matrix job can resolve the local action when checking out those branches.
xintongsong
pushed a commit
to apache/flink-agents
that referenced
this pull request
May 25, 2026
Add a local composite action under .github/actions/rsync-deployments that wraps rsync-over-SSH for documentation deployment. Ported from apache/flink-kubernetes-operator#1035 with MIT attribution preserved. This action is intended to replace the third-party burnett01/rsync-deployments action, which is not in the ASF allowed-actions list. Locally-defined actions are not subject to that allow-list, so they can be used safely in ASF repositories. This commit is purely additive (no existing files modified) and can be cherry-picked cleanly to release branches so the nightly docs matrix job can resolve the local action when checking out those branches.
xintongsong
pushed a commit
to apache/flink-agents
that referenced
this pull request
May 25, 2026
Add a local composite action under .github/actions/rsync-deployments that wraps rsync-over-SSH for documentation deployment. Ported from apache/flink-kubernetes-operator#1035 with MIT attribution preserved. This action is intended to replace the third-party burnett01/rsync-deployments action, which is not in the ASF allowed-actions list. Locally-defined actions are not subject to that allow-list, so they can be used safely in ASF repositories. This commit is purely additive (no existing files modified) and can be cherry-picked cleanly to release branches so the nightly docs matrix job can resolve the local action when checking out those branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.