Skip to content

[FLINK-38858] Reuse jobid after failed submissions to guard against job duplication#1045

Merged
gyfora merged 1 commit into
apache:mainfrom
gyfora:FLINK-38858
Jan 5, 2026
Merged

[FLINK-38858] Reuse jobid after failed submissions to guard against job duplication#1045
gyfora merged 1 commit into
apache:mainfrom
gyfora:FLINK-38858

Conversation

@gyfora
Copy link
Copy Markdown
Contributor

@gyfora gyfora commented Jan 5, 2026

What is the purpose of the change

Currently some session job submission errors such as timeouts can very easily lead to duplicate submissions as jobids are incorrectly rotated even if the operator assumes that submission failed.

Brief change log

  • Do not rotate job ids when submission failed
  • Separate client and job submission timeout with larger default value
  • Unit tests

Verifying this change

Unit tested + tested in prod environments

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changes to the CustomResourceDescriptors: no
  • Core observer or reconciler logic that is regularly executed: yes

Documentation

  • Does this pull request introduce a new feature? no

@gyfora gyfora requested review from gaborgsomogyi and mxm January 5, 2026 06:59
Copy link
Copy Markdown
Contributor

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@gaborgsomogyi gaborgsomogyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gyfora gyfora merged commit e480eb7 into apache:main Jan 5, 2026
172 of 235 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants