[FLINK-38860] Remove flink shaded guava usage#1047
Merged
Conversation
mxm
approved these changes
Jan 5, 2026
| <module name="IllegalImport"> | ||
| <property name="illegalPkgs" value="com.google.common"/> | ||
| <message key="import.illegal" value="{0}; Use flink-shaded-guava instead."/> | ||
| <property name="illegalPkgs" value="org.apache.flink.shaded.guava31"/> |
Contributor
There was a problem hiding this comment.
Should this regex be a bit more general to guard against new shaded guava releases?
Suggested change
| <property name="illegalPkgs" value="org.apache.flink.shaded.guava31"/> | |
| <property name="illegalPkgs" value="org.apache.flink.shaded.guava.*"/> |
Contributor
Author
There was a problem hiding this comment.
I tried different alternatives: shaded.guava, shaded.guava*, shaded.guava.* non of them actually worked unfortunately, so I have given up
Contributor
There was a problem hiding this comment.
This should work:
Suggested change
| <property name="illegalPkgs" value="org.apache.flink.shaded.guava31"/> | |
| <property name="illegalPkgs" regexp="true" value="org.apache.flink.shaded.guava.*"/> |
Note that regex feature needs to be enabled. See https://checkstyle.sourceforge.io/checks/imports/illegalimport.html#Properties
Contributor
|
gaborgsomogyi
approved these changes
Jan 5, 2026
Contributor
gaborgsomogyi
left a comment
There was a problem hiding this comment.
The change looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The kubernetes operator uses flink shaded classes, this can be very problematic if the operator api is used as a library from other apps to submit resources. We should follow the standard best prectice of not using flink shaded classes outside core flink.
Brief change log
Verifying this change
Unit test and test in prod envs
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors: noDocumentation