[FLINK-38077] Make sure jobmanager is accessible when trying to cancel for suspend/upgrade#1050
Merged
Merged
Conversation
…l for suspend/upgrade
mxm
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Cancel job upgrades (last-state without HA or when we fall back from savepoint) currently can get indefinitely stuck if the JobManager deployment is missing or otherwise the REST API not accessible.
This is caused by a bug in the "isCancellable" logic that decides that cancel should be used for upgrade or not.
Verifying this change
Unit tests added, tested in various environments
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors: noDocumentation