[FLINK-37126] Add Validator for Autoscaler#936
Merged
Conversation
92a1be4 to
15982fd
Compare
439229b to
85675ee
Compare
24edc0d to
bcbdf4c
Compare
Contributor
|
Any update on this? |
Contributor
Author
Thanks for @gyfora ping, it's been too long I forgot about this PR, I'll keep pushing forward |
bcbdf4c to
e9eec8f
Compare
Contributor
Author
|
@gyfora Could you help review this PR when you have time? Thank you very much ~ |
gyfora
requested changes
Sep 17, 2025
Contributor
gyfora
left a comment
There was a problem hiding this comment.
The changes look good, but I would remove the extra interface added
| import static org.apache.flink.autoscaler.config.AutoScalerOptions.UTILIZATION_TARGET; | ||
|
|
||
| /** Default implementation of {@link AutoscalerValidator}. */ | ||
| public class DefaultAutoscalerValidator implements AutoscalerValidator { |
Contributor
There was a problem hiding this comment.
Instead of making this an interface with a default implementation, can we simply make this a regular class and just use it directly? AutoscalerValidator that contains the implementation. If later we want to make it pluggable then we can extract the interface but now this is just boilerplate
7fe848a to
3c28969
Compare
8391a13 to
4fd3432
Compare
gyfora
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add Validator for Autoscler, Facilitates StandaloneAutoscaler to detect configuration anomalies in advance
Brief change log
DefaultAutoscalerValidatorto the Autoscaler moduleVerifying this change
This change added tests and can be verified as follows:
StandaloneAutoscalerValidatorTestUsed to verify parameter verification under standloneAutoscalerDoes this pull request potentially affect one of the following parts:
CustomResourceDescriptors: (no)Documentation