[FLINK-39118] Add documentation for Native s3 FileSystem#27841
[FLINK-39118] Add documentation for Native s3 FileSystem#27841Samrat002 wants to merge 4 commits intoapache:masterfrom
Conversation
alpinegizmo
left a comment
There was a problem hiding this comment.
This is in pretty good shape. Just a couple of points to address.
7b82717 to
7be000d
Compare
alpinegizmo
left a comment
There was a problem hiding this comment.
One more suggestion, and a question.
Izeren
left a comment
There was a problem hiding this comment.
Thank you for the PR @Samrat002, I have left a few comments, PTAL.
My general request for changes is to replicate this for Chinese docs (usually we update both): https://github.com/apache/flink/blob/master/docs/content.zh/docs/deployment/filesystems/s3.md
It can be done in English for further translation.
| s3.retry.max-num-retries: 3 | ||
|
|
||
| # Credentials provider | ||
| fs.s3.aws.credentials.provider: software.amazon.awssdk.auth.credentials.DefaultCredentialsProvider |
There was a problem hiding this comment.
The default is noDefaultValue for this config:
Which may be a bit confusing this way. Should we have it explicitly in the config if this is our intention?
|
|
||
| ```yaml | ||
| s3.path.style.access: true | ||
| s3.path-style-access: true |
There was a problem hiding this comment.
Will we have any backwards compatibilty problem with config property name being changed?
What is the purpose of the change
Add documentation for Native s3 FileSystem
Please note that this patch does not update the Chinese document yet. This will be done once english document content is reached to consensus.
Brief change log
Add documentation and show how to use new s3Filesystem.
Verifying this change
Build the docs in local using Hugo
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation
Does this pull request introduce a new feature? (yes / no) no
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) yes