[FLINK-39392][table] Support conditional traits for PTFs#27886
Draft
gustavodemorais wants to merge 4 commits intoapache:masterfrom
Draft
[FLINK-39392][table] Support conditional traits for PTFs#27886gustavodemorais wants to merge 4 commits intoapache:masterfrom
gustavodemorais wants to merge 4 commits intoapache:masterfrom
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
We'd like to make PTF traits configurable so we can have multiple versions depending on how they are configured by the user.
The first suggestion: introduce a declarative addTraitWhen API on StaticArgument that allows table argument traits to vary based on the SQL call context (e.g., whether PARTITION BY is provided or scalar argument values). This replaces the static
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation