Skip to content

Commit 1735e4d

Browse files
authored
chore: fix typos (#2496)
<!-- **Thanks for contributing to Fory.** **If this is your first time opening a PR on fory, you can refer to [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).** Contribution Checklist - The **Apache Fory** community has requirements on the naming of pr titles. You can also find instructions in [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md). - Fory has a strong focus on performance. If the PR you submit will have an impact on performance, please benchmark it first and provide the benchmark result here. --> ## What does this PR do? fix typos <!-- Describe the purpose of this PR. --> ## Related issues <!-- Is there any related issue? Please attach here. - #xxxx0 - #xxxx1 - #xxxx2 --> ## Does this PR introduce any user-facing change? <!-- If any user-facing interface changes, please [open an issue](https://github.com/apache/fory/issues/new/choose) describing the need to do so and update the document if necessary. --> - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here. -->
1 parent 6f54e19 commit 1735e4d

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

java/fory-core/src/main/java/org/apache/fory/codegen/Expression.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2432,7 +2432,7 @@ public ExprCode doGenCode(CodegenContext ctx) {
24322432
action.apply(
24332433
new Reference(i),
24342434
new Reference(leftElemValue, leftElemType, true),
2435-
// elemValue nullability check use isNullAt inside action, so elemValueRef'nullable is
2435+
// elemValue nullability check uses isNullAt inside action, so elemValueRef's nullable is
24362436
// false.
24372437
new Reference(rightElemValue, rightElemType, false));
24382438
ExprCode elementExprCode = elemExpr.genCode(ctx);

java/fory-format/src/main/java/org/apache/fory/format/encoder/ArrayDataForEach.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public Code.ExprCode doGenCode(CodegenContext ctx) {
110110
String i = freshNames[0];
111111
String elemValue = freshNames[1];
112112
String len = freshNames[2];
113-
// elemValue is only used in notNullAction, so set elemValueRef'nullable to false.
113+
// elemValue is only used in notNullAction, so set elemValueRef's nullable to false.
114114
Reference elemValueRef = new Reference(elemValue, elemType);
115115
Code.ExprCode notNullElemExprCode =
116116
notNullAction.apply(new Reference(i), elemValueRef).genCode(ctx);

python/pyfory/_serialization.pyx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -388,9 +388,9 @@ cdef class TypeInfo:
388388
for python `int`: `Int8/1632/64/128Serializer` for `int8/16/32/64/128` each, and another
389389
`IntSerializer` for `int` which will dispatch to different `int8/16/32/64/128` type
390390
according the actual value.
391-
We do not get the acutal type here, because it will introduce extra computing.
391+
We do not get the actual type here, because it will introduce extra computing.
392392
For example, we have want to get actual `Int8/16/32/64Serializer`, we must check and
393-
extract the actutal here which will introduce cost, and we will do same thing again
393+
extract the actual here which will introduce cost, and we will do same thing again
394394
when serializing the actual data.
395395
"""
396396
cdef public object cls
@@ -1555,7 +1555,7 @@ cdef inline get_next_element(
15551555
typeinfo = type_resolver.read_typeinfo(buffer)
15561556
cdef int32_t type_id = typeinfo.type_id
15571557
# Note that all read operations in fast paths of list/tuple/set/dict/sub_dict
1558-
# ust match corresponding writing operations. Otherwise, ref tracking will
1558+
# must match corresponding writing operations. Otherwise, ref tracking will
15591559
# error.
15601560
if type_id == <int32_t>TypeId.STRING:
15611561
return buffer.read_string()

0 commit comments

Comments
 (0)