Skip to content

Commit 8c0fdca

Browse files
authored
ci: Fix Windows wheel creation (#2511)
## Why? * Wheels were not created on Windows because it does not use bash by default * Once that works, downloading them will fail because `actions/download-artifact` requires the `run-id` to access artifacts from different workflows. ## What does this PR do? * Add `actions: read` permission to release workflow. * Configure `download-artifact` action to use `run-id` and `pattern` for downloading wheels from a previous workflow run. * Enable `merge-multiple` for downloading artifacts. * Add `shell: bash` to build step in native release workflow. ## Related issues #2506
1 parent 8d30984 commit 8c0fdca

2 files changed

Lines changed: 5 additions & 0 deletions

File tree

.github/workflows/build-native-release.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ jobs:
4242
run: ./ci/run_ci.sh install_bazel_windows
4343
shell: bash
4444
- name: Build wheel
45+
shell: bash
4546
run: ./ci/deploy.sh build_pyfory
4647
- name: Install and verify wheel
4748
shell: bash

.github/workflows/release-python.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ on:
2525
permissions:
2626
contents: read
2727
id-token: write
28+
actions: read # for accessing workflow run artifacts
2829

2930
jobs:
3031
publish-wheels:
@@ -35,7 +36,10 @@ jobs:
3536
- name: Download all wheel artifacts
3637
uses: actions/download-artifact@v5
3738
with:
39+
run-id: ${{ github.event.workflow_run.id }}
40+
pattern: "pyfory-wheels-*"
3841
path: downloaded_wheels
42+
merge-multiple: true
3943

4044
- name: Move wheels to a single directory
4145
shell: bash

0 commit comments

Comments
 (0)