Skip to content

Commit a5d1c77

Browse files
fix(benchmarks): uses outdated google-java-format, upgrade spotless (#3722)
## Why? Style format blocked my other PR, tried to run `bash ci/format.sh --java` but it fails due to using JDK 26 ## What does this PR do? Bring benchmarks project spotless google-java-format in line with parent pom ## AI Contribution Checklist - [ ] Substantial AI assistance was used in this PR: No ## Does this PR introduce any user-facing change? No
1 parent 297c345 commit a5d1c77

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

benchmarks/java/pom.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -403,8 +403,7 @@
403403
<exclude>**/generated/**/*.java</exclude>
404404
</excludes>
405405
<googleJavaFormat>
406-
<!-- 1.19.1 support JDK21 -->
407-
<version>1.19.1</version>
406+
<version>${google-java-format.version}</version>
408407
<style>GOOGLE</style>
409408
</googleJavaFormat>
410409
</java>

java/pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,8 @@
7474
<janino.version>3.1.12</janino.version>
7575
<commons_codec.version>1.13</commons_codec.version>
7676
<fory.java.rootdir>${basedir}</fory.java.rootdir>
77-
<maven-spotless-plugin.version>3.3.0</maven-spotless-plugin.version>
77+
<maven-spotless-plugin.version>3.6.0</maven-spotless-plugin.version>
78+
<google-java-format.version>1.35.0</google-java-format.version>
7879
<lombok.version>1.18.38</lombok.version>
7980
<mockito.version>4.11.0</mockito.version>
8081
</properties>
@@ -272,8 +273,7 @@
272273
<configuration>
273274
<java>
274275
<googleJavaFormat>
275-
<!-- 1.35 support JDK25 -->
276-
<version>1.35.0</version>
276+
<version>${google-java-format.version}</version>
277277
<style>GOOGLE</style>
278278
</googleJavaFormat>
279279
</java>

0 commit comments

Comments
 (0)