Skip to content

Commit cf11083

Browse files
esafakchaokunyang
authored andcommitted
ci: Fix verify_version() by capturing version properly (#2535)
## Why? [Containerized builds were failing at the version verification step](https://github.com/apache/fory/actions/runs/17257282639/job/48971637440#step:5:1997). ## What does this PR do? * Refine script to capture only the actual version output from deploy.sh.
1 parent f6a7273 commit cf11083

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

ci/deploy.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@
1919

2020

2121
# Print commands and their arguments as they are executed.
22-
set -x
22+
if [ "${DEPLOY_QUIET:-0}" != "1" ]; then
23+
set -x
24+
fi
2325

2426
# Cause the script to exit if a single command fails.
2527
set -e

ci/tasks/python_container_build_script.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ verify_version() {
3232

3333
# Check if GITHUB_REF_NAME is available and use it for verification
3434
if [ -n "$GITHUB_REF_NAME" ]; then
35-
# Strip leading 'v' if present
35+
# Strip leading 'v' if present and capture only the actual output, not debug messages
3636
local expected_version
37-
expected_version="$(ci/deploy.sh parse_py_version $GITHUB_REF_NAME)"
37+
expected_version="$(DEPLOY_QUIET=1 ci/deploy.sh parse_py_version $GITHUB_REF_NAME)"
3838
echo "Expected version: $expected_version"
3939

4040
if [ "$installed_version" != "$expected_version" ]; then

0 commit comments

Comments
 (0)