Skip to content

chore: fix typos #2496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaokunyang merged 1 commit into from
Aug 22, 2025
Merged

chore: fix typos #2496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java/fory-core/src/main/java/org/apache/fory/codegen/Expression.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2432,7 +2432,7 @@ public ExprCode doGenCode(CodegenContext ctx) {
action.apply(
new Reference(i),
new Reference(leftElemValue, leftElemType, true),
// elemValue nullability check use isNullAt inside action, so elemValueRef'nullable is
// elemValue nullability check uses isNullAt inside action, so elemValueRef's nullable is
// false.
new Reference(rightElemValue, rightElemType, false));
ExprCode elementExprCode = elemExpr.genCode(ctx);
Expand Down
2 changes: 1 addition & 1 deletion java/fory-format/src/main/java/org/apache/fory/format/encoder/ArrayDataForEach.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public Code.ExprCode doGenCode(CodegenContext ctx) {
String i = freshNames[0];
String elemValue = freshNames[1];
String len = freshNames[2];
// elemValue is only used in notNullAction, so set elemValueRef'nullable to false.
// elemValue is only used in notNullAction, so set elemValueRef's nullable to false.
Reference elemValueRef = new Reference(elemValue, elemType);
Code.ExprCode notNullElemExprCode =
notNullAction.apply(new Reference(i), elemValueRef).genCode(ctx);
Expand Down
6 changes: 3 additions & 3 deletions python/pyfory/_serialization.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,9 +388,9 @@ cdef class TypeInfo:
for python `int`: `Int8/1632/64/128Serializer` for `int8/16/32/64/128` each, and another
`IntSerializer` for `int` which will dispatch to different `int8/16/32/64/128` type
according the actual value.
We do not get the acutal type here, because it will introduce extra computing.
We do not get the actual type here, because it will introduce extra computing.
For example, we have want to get actual `Int8/16/32/64Serializer`, we must check and
extract the actutal here which will introduce cost, and we will do same thing again
extract the actual here which will introduce cost, and we will do same thing again
when serializing the actual data.
"""
cdef public object cls
Expand Down Expand Up @@ -1555,7 +1555,7 @@ cdef inline get_next_element(
typeinfo = type_resolver.read_typeinfo(buffer)
cdef int32_t type_id = typeinfo.type_id
# Note that all read operations in fast paths of list/tuple/set/dict/sub_dict
# ust match corresponding writing operations. Otherwise, ref tracking will
# must match corresponding writing operations. Otherwise, ref tracking will
# error.
if type_id == <int32_t>TypeId.STRING:
return buffer.read_string()
Expand Down
Loading